Re^2: Basic Coding Tips: Parsimonious Parameterization

Well, if you want a "WTF", I found this gem on cpan a while ago:

#merges the elements of two or more arrays together so that the values
+ of one 
# are appended to the end of the previous one
sub array_merge{
    my(@array1, @array2) = @_;
    foreach my $element (@array2){
        @array1 = (@array1, $element);
    }#foreach
    return @array1;
}#array_merge
[download]

Comment on Re^2: Basic Coding Tips: Parsimonious Parameterization Download Code

Replies are listed 'Best First'.
Re^3: Basic Coding Tips: Parsimonious Parameterization by Tanktalus (Canon) on Jan 29, 2005 at 05:09 UTC
I have to admit - he couldn't do it much faster than that and still have a subroutine... (Anyone else notice that @array2 will always be empty since @array1 will get all of @_? Thus, the foreach will always be skipped!)	[reply]
Re^4: Basic Coding Tips: Parsimonious Parameterization by wazoox (Prior) on Jan 31, 2005 at 12:37 UTC
Yes :) But it'd works this way: `sub array_merge(\@\@){ my($array1, $array2) = @_; foreach my $element (@$array2){ @$array1 = (@$array1, $element); }#foreach return @$array1; }#array_merge my @t=array_merge(@liste1, @liste2);` [download]	[reply] [d/l]
Re^5: Basic Coding Tips: Parsimonious Parameterization by bart (Canon) on Jan 31, 2005 at 15:58 UTC
`my @t = (@liste1, @liste2);` [download] works too. No need to reinvent what the core language already provides in a simple way.	[reply] [d/l]