in reply to Refactoring challenge.

This code is a mess, but works. Can you refactor it?

Sure. First, show me your unit tests, so that I can have confidence that my refactorings aren't breaking any unstated assumptions. In particular, on first read of the code, I'd want to see the tests that demonstrate (and document) what you expect 

    $str =~ s[^.{$pos1}\s*][];

[download]
to do and not do. Otherwise, I'd be left making educated guesses. That might work, or it might not.

Replies are listed 'Best First'.
Re^2: Refactoring challenge.
by BrowserUk (Patriarch) on Mar 06, 2005 at 18:32 UTC 
    $str =~ s[^.{$pos1}\s*][];

    [download]

    removes $pos1 characters from the front of the string, plus (optionally) any whitespace that immediately follows them. Not complicated but necessary.

    As for the unit tests, that would require I publish several hundred lines of support code, which would be a bit much to expect any to look through.

    Otherwise, I'd be left making educated guesses. That might work, or it might not.

    Fair enough. I wasn't asking for a perfect working solution, just some fresh ideas to set me on my way, which dragonchild and hv both gave me.

    Examine what is said, not who speaks.
    Silence betokens consent.
    Love the truth but pardon error.
[reply]
[d/l]
Re^2: Refactoring challenge.
by BrowserUk (Patriarch) on Mar 07, 2005 at 01:03 UTC

    There is a testcase at 437114.

    Examine what is said, not who speaks.
    Silence betokens consent.
    Love the truth but pardon error.
[reply]

In Section Seekers of Perl Wisdom