archive-zip problem

dorianwinterfeld has asked for the wisdom of the Perl Monks concerning the following question:

Here's the problem. I have a list of html files on a Windows box that I want to zip using Archive-Zip. No matter what I do I get an empty zip file. Here's the code, see below. $server_root is the doc root of IIS, d:/online.I use CGI because this must be triggered thru a web interface. What am I doing wrong?

use CGI qw/:standard/;
use CGI::Carp (fatalsToBrowser);
use Archive::Zip qw( :ERROR_CODES :CONSTANTS );
use lib '..';
require 'globals.plx';
require './config.plx';

print header;
open FH,$vsc_log;
my @files = <FH>;
close FH;

print qq(change dir to $server_root),br;
chdir "$server_root" or "Can't cd to $server_root: $!"; 

my $zip = Archive::Zip->new();
foreach my $file (@files){
    $file =~ s@d:/online/@@;
    $file =~ s@/@\\@g;
    print "add $file",br;
    $zip->addFile("$file");
}

print qq(write $vsc_zip),br;
die 'write error' unless $zip->writeToFileNamed( $vsc_zip ) == AZ_OK;
[download]

thanks for your help - Dorian

Comment on archive-zip problem Download Code

Replies are listed 'Best First'.
Re: archive-zip problem by fglock (Vicar) on Mar 28, 2005 at 13:34 UTC
Maybe you have to `chomp @files` ?	[reply] [d/l]
Re^2: archive-zip problem by dorianwinterfeld (Acolyte) on Mar 28, 2005 at 18:48 UTC
Brilliant! Thank you, that was it!	[reply]
Re: archive-zip problem by derby (Abbot) on Mar 28, 2005 at 13:41 UTC
You should ~~probably~~ check your open call (and check if $vsc_log is empty)? `die "Error: $vsc_log does not exist" unless -e $vsc_log; die "Error: $vsc_log is empty" unless -s $vsc_log; open( FH, "< $vsc_log" ) or die "Cannot open $vsc_log: $!";` [download] -derby	[reply] [d/l]