in reply to How would you rewrite this?

Maybe something like (as others have said, assuming no copy/paste errors):
my @checks = ( [ qw/0 agency_id agency_id / ], [ qw/1 advertiser advertiser / ], [ qw/2 compaign_id compaign_id / ], [ qw/3 contact_id admin_contact_id / ], [ qw/3 contact_id tech_contact_id / ], ); foreach my $check (@checks){ my( $idx, $key, $k ) = @$check; get_updates($objects[$idx], $key, $result_ref->{$k}) if (defined $result_ref->{$k} && $result_ref->{$k} != 0); }
Update: Changed "$result_ref->{'agency_id'} != 0" to "$result_ref->{$k} != 0" to reflect OP's correction.

Replies are listed 'Best First'.
Re^2: How would you rewrite this?
by dragonchild (Archbishop) on Apr 27, 2005 at 12:40 UTC
    You can improve that.
    my @checks = ( [ qw/0 agency_id agency_id / ], [ qw/1 advertiser advertiser / ], [ qw/2 compaign_id compaign_id / ], [ qw/3 contact_id admin_contact_id / ], [ qw/3 contact_id tech_contact_id / ], ); foreach my $check (@checks){ my( $idx, $key, $k ) = @$check; (defined $result_ref->{$k} && $result_ref->{$k} != 0) && get_updates($objects[$idx], $key, $result_ref->{$k}); }

    Note that means that $result_ref->{$k} is allowed to be the empty string. If it's not, then it's better written as a simple check for boolean truth.

    $result_ref->{$k} && get_updates($objects[$idx], $key, $result_ref->{$k});

    In Perl6, that could look like:

    my @checks = qw( 0 agency_id agency_id 1 advertiser advertiser 2 compaign_id compaign_id 3 contact_id admin_contact_id 3 contact_id tech_contact_id ); for (@checks) -> ($idx, $key, $check) { $result_ref->{$check} && get_updates( @objects[$idx], $key, $result_ref->{$check} ); }

    The Perfect is the Enemy of the Good.

Re^2: How would you rewrite this?
by jacques (Priest) on Apr 27, 2005 at 01:52 UTC
    Change that last hash key to $k and it looks good to me! Thanks.