Re: Code refactoring challenge

There are a couple of other things that I don't care for in this example in addition to the large list of my my my's.

Calling functions with &. It isn't needed in most cases, none of which I see in this code.
Generating raw SQL without binding columns. There are very few cases where you should not bind columns. This isn't one of them.
Using the results of $#{ $data } with a while loop. foreach, last and next are your friends.

Comment on Re: Code refactoring challenge

Replies are listed 'Best First'.
Re^2: Code refactoring challenge by castaway (Parson) on Apr 30, 2005 at 08:42 UTC
No, & isnt needed, but it's already in all the rest of the code (9 .pm files totalling 600k), so removing them all would be a bit of work, I'd rather stay consistent for now. Ah, but you missed the entire point there, the SQL isnt actually needed at all, it's just using the database engine as a caculator, so I removed it completely. If you look, you'll see I did change that to a for-loop. (Although admittedly it could have been better still), the index is needed because it grabs the next line after the one we are looking at, too. C.	[reply]

Replies are listed 'Best First'.

Re^2: Code refactoring challenge
by castaway (Parson) on Apr 30, 2005 at 08:42 UTC

Ah, but you missed the entire point there, the SQL isnt actually needed at all, it's just using the database engine as a caculator, so I removed it completely.

If you look, you'll see I did change that to a for-loop. (Although admittedly it could have been better still), the index is needed because it grabs the next line after the one we are looking at, too.

[reply]