Useless use of private variable

Bud Man has asked for the wisdom of the Perl Monks concerning the following question:

I am receiving this error message:

Useless use of private variable in void context at /var/www/.dada_files/.bounce_handler/dada_bounce_handler.pl line 1106.

This is the relevant code, the last line being line 1106.


if((!$list) || (!$email) || !keys %{$diagnostics}){
    my ($qmail_list, $qmail_email, $qmail_diagnostics) = parse_for_qma
+il($entity);
    $list  ||= $qmail_list;
    $email ||= $qmail_email;
    $diagnostics = ($diagnostics, $qmail_diagnostics);
[download]

I am not sure how to correct this problem.

Ciao

Comment on Useless use of private variable Download Code

Replies are listed 'Best First'.
Re: Useless use of private variable by merlyn (Sage) on May 01, 2005 at 15:41 UTC
`$diagnostics = ($diagnostics, $qmail_diagnostics);` [download] What are you expecting that line to do? That's the equivalent of: `$diagnostics = $qmail_diagnostics;` [download] What did you mean instead? -- Randal L. Schwartz, Perl hacker Be sure to read my standard disclaimer if this is a reply.	[reply] [d/l] [select]