Re: Hints for getting this perly...

My 2 cents,

The code has a syntax error: (the ')' on the utime-line)
no need to label the loop, but that's not a big problem though
The style of the script could be better
\d\d\d\d can be written as \d{4} which is lots shorter
Using grep to select ALL elements matching a regex from the file, only using the first one that matches, and then the same regex again on it... perhaps a for/while loop would be better?
Reading the file in memory is not something I would do... I would probably put the date-regex in the main-while loop... (while (<F>))

Comment on Re: Hints for getting this perly...

Replies are listed 'Best First'.
Re^2: Hints for getting this perly... by Animator (Hermit) on May 11, 2005 at 08:55 UTC
Hmm, apperently I wasn't logged in... (the previous post is mine too) Another note: instead of `$in_text` you can use the .. operator. (something like `if (m#<div ...># .. m#</div>#) { ...` Also, you are doing a match, but not checking if it returns true or false, and then go on using `$1`... If the match fails then you will end up using `$1` from the previous match, and that might corrupt data... Update: a good document about the style (I mean the indeting etc) is the perlstyle POD The main thing that botters me is that last READ etc start at the same position as your elsif... (or is that only the way it is displayed here?)	[reply] [d/l] [select]
Re^3: Hints for getting this perly... by hynek (Novice) on May 11, 2005 at 09:10 UTC
Ah I see, it's just here. Of course I indent my code...dunno why it's fubared here. :( However I'd say that the ...-operator won't work, when working line-wise?	[reply]
Re^2: Hints for getting this perly... by hynek (Novice) on May 11, 2005 at 09:00 UTC
Could you elaborate on the style? That's one of the points I'm hunting in special. I'm an old C-fellow and changing habits is hard. :( I'll try to implement the rest though and'll post the result here.	[reply]