Re: form checking checkboxes

Why not simply check if they are each one digit, and then if that one digit is within the valid range:

use strict;
use warnings;

for (qw(1 5 10 a 4)) {
    warn "$_ is not an int\n" unless $_ =~ /\d/;
    warn "$_ is out of range\n" unless $_ >= 1 && $_ <= 7;
}
[download]

I use warn instead of die just to demonstrate checking all the "test data," and to demonstrate why you want to make sure the data is indeed a number before you try to compare it with numerical operators.

UPDATE: I left out discussion of untainting the values. Don't. If the data is invalid, then stop form processing. Make the user give you valid data. Naturally, you don't want to die in that case, but instead return the form with an error message (and hopefully the rest of their submitted, valid values intact).

UPDATE^2: Thanks for the catch ikegami. Got any snake venom handy?

jeffa

L-LL-L--L-LL-L--L-LL-L--
-R--R-RR-R--R-RR-R--R-RR
B--B--B--B--B--B--B--B--
H---H---H---H---H---H---
(the triplet paradiddle with high-hat)

Comment on Re: form checking checkboxes Download Code

Replies are listed 'Best First'.
Re^2: form checking checkboxes by thundergnat (Deacon) on May 31, 2005 at 20:18 UTC
Or even simpler... `#!/usr/local/bin/perl use warnings; use strict; for (qw(1 5 10 a 4 0 deadbeef 357 Albuquerque)) { warn "Bad input $_\n" and next unless /^([1-7])$/; print "Good input $1\n"; }` [download] Update: erp! Left out untainting bit. Minor edit to untaint data.	[reply] [d/l]
Re^2: form checking checkboxes by ikegami (Patriarch) on May 31, 2005 at 20:17 UTC
According to your code "l33t" in an int. According to your code "4c3" is not only an int, it's in range. `if $_ =~ /\D/` would be better than `unless $_ =~ /\d/`	[reply] [d/l] [select]