in reply to Re^2: mship.pm
in thread mship.pm - my first module

So, Ted, you've received lots of feedback on how to improve the code, yet you're thus far silent in both threads as to whether you've accepted the feedback, and if you have accepted the comments, you should probably update the original "snippet" above...

The Critical comments made thus far are, in this case, not personal attacks. Silence from you makes it seem like you're not interested in the feedback you've received.

Simply posting random code without a story as to what the code does, and why someone else might find it valuable means you've relagated such code to the bottom of the dustbin of snippets. You cared enough to post it originally, don't let a few critical comments make you abandon your case, fix it, make it better, make it usable to others, and state why you think it should be used by others.

-Scott

Replies are listed 'Best First'.
Re^4: mship.pm
by tcf03 (Deacon) on Jun 20, 2005 at 23:46 UTC
    Updated mship.pm - my first module
    Ted
    --
    The most moral activity of all is the creation of space for life to move around.
      --Robert M. Pirsig