Re^2: Mail:Audit Resend Problem

Here is the code I have written:

#!/usr/bin/perl

#Declare packages to be used always including strict and utf8
use strict;
use utf8;
use Mail::Audit;
use IO::Handle;
use DBI;

#Connect to the database
my $dbh = DBI->connect("dbi:Pg:dbname=database", "user", "password", {
+AutoCommit => 0});

#Declare variables to be used including command line variables if need
+ed
my ($stored_email, $log, $to, $from, $forward_address, $store, $body, 
+$sql, $sth, $date, $local_address);
my (@filter, @row);
my (%forward);
my ($sec,$min,$hour,$mday,$mon,$year,$wday,$yday,$isdst) = localtime(t
+ime);
$date = "$mday/$mon/$year $hour:$min:$sec";

#Create any functions necessary

#Main body of program
##Set variable values
$sql = "SELECT \"ForwardMailTo\", \"ForwardMailFrom\"
        FROM \"tblForwardMail\"";
$sth = $dbh->prepare($sql);
$sth->execute;
while (@row = $sth->fetchrow) {
    $forward{$row[0]} = $row[1];
}
$stored_email = "stored_mail.txt";
$log = "audit_mail.log";
$store = "NO";

##Open the log file
open (LOG, ">>$log") or die "$date --- Couldn't open $log";

##See if there is a match for the to email to find the forward address
my $incoming = Mail::Audit->new;
$to = $incoming->to();
$from = $incoming->from();

##Test to see if the to address exists and map the forwarding address
while(my ($key, $value) = each(%forward)) {
    if ($to =~ $key) {
        $local_address = $key;
        $forward_address = $value;
    }
}

if ($forward_address) {
    print LOG "$date --- $to has been mapped to $forward_address\n";
    $sql = "SELECT \"tblForwardMail\".\"ForwardMailID\", \"tblFilterMa
+il\".\"FilterMailEmail\"
            FROM \"tblForwardMail\"
            LEFT JOIN \"tblFilterMail\" ON \"tblForwardMail\".\"Forwar
+dMailID\"=\"tblFilterMail\".\"ForwardMailID\"
            WHERE \"tblForwardMail\".\"ForwardMailTo\"='$local_address
+'";
    $sth = $dbh->prepare($sql);
    $sth->execute;
    while (@row = $sth->fetchrow) {
        push(@filter, $row[1]);
    }
}
else {
    print LOG "$date --- No mapping for $to\n";
    close (LOG);
    exit();
}

##Check to see if the from address is part of the filter list
print LOG "$date --- Searching for filter email.\n";
foreach my $email_address(@filter) {
    if (($from =~ $email_address)){
        $store = "YES";
    }
}

##Either store the email and forward it or just forward the email
if ($store eq "YES") {
    open (OUTPUT, ">>$stored_email") or print LOG "$date --- Couldn't 
+open $stored_email.\n";
    print OUTPUT @{$incoming->body()};
    print OUTPUT "##--------------------------------------------------
+-------------##";
    close(OUTPUT);
    print LOG "$date --- Filter address found. $to has been forwarded 
+to $forward_address\n";
    $incoming->resend($forward_address) or print LOG "$date --- Couldn
+'t forward to $forward_address\n";
}
else {
    print LOG "$date --- No filter address found.  $to has been forwar
+ded to $forward_address.\n";
    $incoming->resend($forward_address) or print LOG "$date --- Couldn
+'t forward to $forward_address\n";
}

##Close the log file
close (LOG);
$dbh->disconnect();
[download]

Comment on Re^2: Mail:Audit Resend Problem Download Code

Replies are listed 'Best First'.
Re^3: Mail:Audit Resend Problem by davidrw (Prior) on Jun 21, 2005 at 14:06 UTC
First, a few code comments: 0) (Update:) Doh--i missed one of the first and foremost things-- add `use strict;` and `use warnings;` !!! 1) For this, check `perldoc -f localtime`: `my ($sec,$min,$hour,$mday,$mon,$year,$wday,$yday,$isdst) = localtime(t +ime); $date = "$mday/$mon/$year $hour:$min:$sec"; # THIS IS WRONG!!!! # do something like this instead: my @time = localtime; my $date = sprintf("%2d/%2d/%4d %02d:%02d:%02d", $time[4] + 1, $time[3 +], $time[5] + 1900, @time[2,1,0]);` [download] 2) This (look at `perldoc -f exists`): `while(my ($key, $value) = each(%forward)) { if ($to =~ $key) { $local_address = $key; $forward_address = $value; } }` [download] should be replaced with: `if( exists $forward{$to} ){ $local_address = $key; $forward_address = $value; }` [download] 3) Use (see DBI docs) heredocs and placeholders. (Also, i believe this 'LEFT JOIN' should be just 'JOIN') $sql = <<EOF; SELECT "tblForwardMail"."ForwardMailID", "tblFilterMail"."FilterMailEm +ail" FROM "tblForwardMail" LEFT JOIN "tblFilterMail" ON "tblForwardMail"."ForwardMail +ID"="tblFilterMail"."ForwardMailID" WHERE "tblForwardMail"."ForwardMailTo"=? EOF # $sth = $dbh->prepare($sql); # $sth->execute( $local_address ); # while (@row = $sth->fetchrow) { # push(@filter, $row[1]); # } # # But it seems like what you want next is just: (undef,$filter_address) = $dbh->selectrow_array($dbh,{},$local_address +); # make sure to pre-declare $filter_address [download] 4) This: `foreach my $email_address(@filter) { if (($from =~ $email_address)){ $store = "YES"; } }` [download] could be: `$store = "YES" if grep( $_ eq $from, @filter );` [download] but if you use my comment #3, then it's just: `$store = "YES" if $from eq $filter_address;` [download] BUT, you should treat $store as a boolean and give it true (1) and false (0, undef) values, so you don't have to string match 'YES' later.. `$store = 1; # true $store = 0; # false if( $store ){ ... } if( ! $store ){ ... }` [download] 5) This: `#Declare variables to be used including command line variables if need +ed my ($stored_email, $log, $to, $from, $forward_address, $store, $body, +$sql, $sth, $date, $local_address);` [download] is "c-ish" .. here it's usally better to declare stuff just when it's being used (especially if it only exists in a limited block/scope) gotta cut back to work for a moment ;) but then i'll go back and see if can find the bug..	[reply] [d/l] [select]
Re^4: Mail:Audit Resend Problem by tertullian01 (Acolyte) on Jun 21, 2005 at 17:23 UTC
Thank you for your comments. I will be the first to admit my Perl is really rusty since I have moved from a system admin role to primarily PHP web development. But on with the comments. I have taken some of you comments to heart and implemented them including (corresponding numbers to your comments): 0)`use warnings;` 1)Proper use of `localtime` and `sprintf` 3)Fixing the sql statements 4)Making store boolean rather than string My comments on your other suggestions follow: 2)The reason I am using the while statement rather than just using exists is because I have found the address that I pull out of the email can be the pure email address (test@test.com) or the email address with a name ("TEST USER" <test@test.com>). Using the while statement allows me to use an approximate match. 3)I am not using the more simplified selectrow_array that you suggested because there could be many addresses to filter and so those need to be stored in an array 4)Although I using boolean rather than string I have kept the foreach in there fore the same reason as number 2 above. I need to do an approximate match rather than an exact match. I think part of the problem you are having in diagnosing is an incomplete description on my part. We are setting up a forwarding server where people can have an email address on our domain that forwards to their own personal email address. What we are hoping is people that have ocntacts around the world will sign up and allow us to harvest the body of their email to look at linguistic problems so as a result the setup is this. Each email address in our domain will forward to one personal email address and according to the user's contacts and what they submit to us each email will be stripped and stored for further linguistic analysis. I hope that clears it up more.	[reply] [d/l] [select]
Re^3: Mail:Audit Resend Problem by Ultra (Hermit) on Jun 21, 2005 at 14:01 UTC
I don't see where your program uses warnings, so could it be that `$forward_address` is undefined ? Dodge This!	[reply] [d/l]
Re^4: Mail:Audit Resend Problem by tertullian01 (Acolyte) on Jun 21, 2005 at 17:24 UTC
I have included `use warnings;` and I get exactly the same result. It works for any and every email address except for the address the email will be forwarded to.	[reply] [d/l]