Re^2: everyauction script error bidding errors

If i replace the code with this;

my $lowest_new_bid;

    if ($#bids) {

        for (my $i=1; $i<scalar(@bids); $i++) {

    my ($alias, $email, $bid, $time, $add1, $add2, $add3, $oqty, $sold
+qty) = &read_bid($bids[$i]);

    if (($form{'ALIAS'} ne $lastbid[0]) && ($form{'ALIAS'} eq $alias))
+ {
    if (($form{'ALIAS'} ne $firstbid[0]) && ($form{'ALIAS'} eq $alias)
+) {
[download]

it works but it now prints all the bids the user has placed on the item and i need it to only display the highest last placed bid but under the current high bid of the highest bidder.

Comment on Re^2: everyauction script error bidding errors Download Code

Replies are listed 'Best First'.
Re^3: everyauction script error bidding errors by mkmcconn (Chaplain) on Jun 21, 2005 at 23:21 UTC
simonwilliams, `if ($#bids){...}` does what you mean, but it doesn't really say what you mean. For that, you should say `if (@bids > 1){ ... }`; i.e., if @bids contains more bids than one, then ... `for (my $i=1; $i<scalar(@bids); $i++) { ... }` could be written ... `for (my $i=1; $i < @bids; $i++) { ... }` ... without any change in meaning. @bids is being evaluated in a scalar context. No need to say scalar() explicitly. Let me oversimplify your problem, and you can build on that. You want to choose the highest bid, excluding your own from consideration (always the first bid), and print only the highest bid. `my $highest; if (@bids > 1){ for (my $i = 1; $i < @bids; $i++) { my ($alias, $email, $bid, $time, $add1, $add2, $add3, $oqty, $soldqty) = read_bid($bids[$i]); $highest = $bid > $highest ? $bid : $highest; } print "Highest bid: $highest\n"; }` [download] mkmcconn	[reply] [d/l] [select]

Replies are listed 'Best First'.

Re^3: everyauction script error bidding errors
by mkmcconn (Chaplain) on Jun 21, 2005 at 23:21 UTC

simonwilliams,

if ($#bids){...}
does what you mean, but it doesn't really say what you mean. For that, you should say
if (@bids > 1){ ... };
i.e., if @bids contains more bids than one, then ...
for (my $i=1; $i<scalar(@bids); $i++) { ... }
could be written ...
for (my $i=1; $i < @bids; $i++) { ... }
... without any change in meaning. @bids is being evaluated in a scalar context. No need to say scalar() explicitly.

Let me oversimplify your problem, and you can build on that. You want to choose the highest bid, excluding your own from consideration (always the first bid), and print only the highest bid.

my $highest;
if (@bids > 1){
    for (my $i = 1; $i < @bids; $i++) {
        my ($alias, 
            $email, 
            $bid, 
            $time, 
            $add1, 
            $add2, 
            $add3, 
            $oqty, 
            $soldqty) = read_bid($bids[$i]);
        $highest = $bid > $highest ? $bid : $highest;
    }
    print "Highest bid: $highest\n";
}
[download]

mkmcconn

[reply]
[d/l]
[select]