in reply to Re^5: Formatting randomised data
in thread Formatting randomised data

Maybe I'm being misunderstood.

I would never fault a beginning Perl programmer for "speaking Perl with a C accent" (see other threads for my description of that).

However, I will always demonstrate "speaking Native Perl" (or "Perl as she is spoke").

In this case, the "int" is definitely redundant, and would get noticed in a code review by my team. Just like the random appearance of "scalar" in definitely scalar contexts, and a dozen other "I don't quite grok Perl" mistakes that I see made on a regular basis.

There is a "native" Perl. I'm teaching it. The llama and the alpaca and the camel define it. My columns and monk postings and usenet comments demonstrate it.

-- Randal L. Schwartz, Perl hacker
Be sure to read my standard disclaimer if this is a reply.

Replies are listed 'Best First'.
Re^7: Formatting randomised data
by monarch (Priest) on Jun 24, 2005 at 08:18 UTC
    I certainly am glad I'm not on your programming team. I am always open to seeing better ways of doing things, but I am very picky about working with open minded individuals that like to be the best in their game..

    My response to your standard disclaimer is "don't expect me to respect you if you can't show respect yourself."

    Also: "don't expect me to think you're good at something if you boast about it a lot." I've met many cowboys in the industry, and they've all got something to prove.

    update: I also believe code reviews, when operating at their best, are about finding and commenting on process flaws or techniques that could seriously affect the program's integrity. Maybe code formatting would be important, too, to a team. But nitpicking about using too many parenthesis to be safe, or the use of int() in a redundant fashion, is less about writing good code and more about showing off.. and when someone older starts boasting that is the right way to do it, it is time to quit that company and look for something better.