@files = grep {  -f "$dir/$_" } readdir(DH);
[download]

use DirHandle;

sub plainfiles {
   my $dir = shift;
   my $dh = DirHandle->new($dir)   or die "can't opendir $dir: $!";
   return sort                     # sort pathnames
          grep {    -f     }       # choose only "plain" files
          map  { "$dir/$_" }       # create full paths
          grep {  !/^\./   }       # filter out dot files
          $dh->read();             # read all entries
}
[download]

Good catch! This is the most reasonable guess so far. I didn't know that failing to closedir may have this side effect. But then I rarely explicitly myself.

use strict;
use warnings;
[download]

$dir =~ m|/$|;  # Do you get the point?!?
[download]

Update: I'm an idiot - it had been chopped, and now I see why you did do it in the first place. Still, it makes for clumsy logic and code, IMHO. PS: $dir does not need to be chopped, and if it did, then it would have been better chomped instead. Also, consider using a more effective indenting style.

Update: ditto as the (update) above!

PS2: now that I look at your script more closely, I feel like pointing out too that since it's not Perl6 yet (thus we do not have zip), your logic is somewhat awkward: why not doing it all in one iteration rather than in two?!? That is what most people would do even if we already had better means to iterate over two arrays in parallel - but maybe even then an AoA would be preferable. TMTOWTDI, you know...

A little walkthrough

$dir="/home/yehuda/img/jpg/";
chop $dir;
[download]

Here you hardcode a string and immedeatly chop off the last char. I cannot make any sense of that.

while (defined ($img=readdir DH)){
$img=~m/^(.*)\.(.*)\.(.*)/g;
$newname="$1.$3";
[download]

Here you do not check if the regex matches. If there is file that does not meet your assumptions it will horribly fail.

push @names,$img;
push @newnames,$newname;
}
[download]

I'm not sure why you don't rename the files immedeatly, but ok. i can live with that. Even if you really have to store the filenames somewhere i would use a hash for that. old name as key, new name as value.

close DH;
[download]

close() closes a filehandle, not a dirhandle. use closedir();

foreach $name(@names){
$i=$i+1 ;
$newname_=$newnames[$i-1];
[download]

Now that is the fun part. You add 1 to $i just to substract the 1 again when you use $i. Better to do the addition after the usage and leave out the substraction.

$path="$dir/$name";
$target="$dir/$newname_";
[download]

Two unneccessary variables.

chomp($target,$path);
[download]

Why chomp? there is no newline insight.

rename ($path,$target) or die "Could not rename:$!";
print "  $path   is now $target \n";
[download]

I'd prefer a warning here instead of sudden death.

After all I doubt that you got this code from the cookbook. And if so, throw it into the trashcan. Slightly improved:

$dir="/home/yehuda/img/jpg";

opendir(DH,$dir)or die "FOO BAR! $!\n";

while ( readdir DH)
{
    if ( -f "$dir/$_" && $m/^(.*)\.(.*)\.(.*)/ )
    {
        warn "cannot rename $dir/$_\n"
            unless rename "$dir/$_", "$dir/$1.$3";
    }
}
closedir DH;
[download]



holli, /regexed monk/

$dir="/home/yehuda/img/jpg/";
chop $dir;
[download]

Here you hardcode a string and immedeatly chop off the last char. I cannot make any sense of that.

It does have some minimal amount of sense, if seen in the awkward context of all the rest of the code. Probably the trailing / conveys him the psychological feeling of having to do with a directory, but then later he does $dir/$somethingelse. Not to justify him - just trying to understand...

Incidetally, why did you post your reply to the OP as a reply to my own reply?!?

#!/usr/bin/perl

use strict;
use warnings;

my $dir='whatever';
chdir $dir;

for (glob "*.*.*") {
    my ($u, undef, $v) = split /\./, $_, 3;
    my $dest="$u.$v";
    rename $_, $dest or 
      die "Can't rename `$_' to `$dest': $!\n";
    print "`$_' => `$dest'\n";
}

__END__
[download]

. didn't match
Could not rename:Device or resource busy at rename0 line 25.
[download]

This is still because you don't check if the file returned is a directory.... In this case it matches '..', so the result is that $1 and $3 are empty, and the image name is '.'. When you try to rename you try to rename  /path/to/directory/. to  /path/to/directory._. To fix this Incorporate a check to see if it is a file or an directory, like mentioned in an earlier post: Re: Rename All Files In a Directory

It would be nice to see the corrected code - I also spotted a syntax error ($success is set inside the if, but then you use $sucess, with one less "c"). You could also put the print line before the rename, just to be sure that you're doing the right thing (note the brackets, just to be sure that there are no spaces):

#....
print "About to rename [$path] to [$target]\n";
rename ($path,$target) or die "Could not rename: $!";
#...
[download]

Moreover, you're probably on some kind of Win32 platform. Are you sure that the file you're trying to rename isn't open by some other application that is "locking" it?

Flavio
perl -ple'$_=reverse' <<<ti.xittelop@oivalf

Don't fool yourself.

Well thanks for the suggestions.I made some upgrades to the code but ultimately wanted to get the job done:so I forged forward at the cmd line and solved the problem with:


perl -e 'opendir(DH,"/home/yehuda/img/jpg");while(defined ($file=readd
+ir(DH))){$file=~m|(.*)\.(.*)\.(.*)|g; rename ($file, $1.$3)}'
[download]