Re: Very very small style question

I prefer either one of these two:

sub method {
  my ($self, $i, $new) = @_;
  my $old = $self->{B}[$i];
  #make sure we have correct number of parameters
  $self->{B}[$i] = $new if @_ > 2;
  return $old;
}
[download]

sub method {
  my ($self, $i, $new) = @_;
  my $old = $self->{B}[$i];
  #make sure we have correct number of parameters
  $self->{B}[$i] = $new if @_ >= 3;
  return $old;
}
[download]

Couldn't you do an (if defined $new) also?

Comment on Re: Very very small style question Select or Download Code

Replies are listed 'Best First'.
Re: Re: Very very small style question by chipmunk (Parson) on Dec 18, 2000 at 07:15 UTC
The one reason for checking the size of @_, rather than whether $_[2] is defined, is that you may actually want to allow someone to call the method with undef as an argument.	[reply]
Re: Very very small style question by Dominus (Parson) on Dec 18, 2000 at 09:20 UTC
Says blogan: > Couldn't you do an (if defined $new) also? No. chipmunk is exactly right here; the function needs to be able to set members of the `B` array to undefined. In fact, an earlier version of the code did use `...if defined $new` and had a terrible bug that led to an infinite loop, because items weren't being set to `undef` when they needed to be. Thanks for the suggestion, though.	[reply]