Re^2: alternatives to if and series of elsif

Interesting.

  return ( $points && min( $Max, $new ) > $quota ) ? $new : $Base;
[download]

Your code (assuming $points is true) reduces the conditional test to a test on the min of the $Max or $new against $quota. I'm trying to understand why it's sufficient without also testing for points against some default value:

   if ($points > 18000 && $quota < 24) {
      return 24;
   }
[download]

Comment on Re^2: alternatives to if and series of elsif Select or Download Code

Replies are listed 'Best First'.
Re^3: alternatives to if and series of elsif by tlm (Prior) on Jul 03, 2005 at 13:38 UTC
Because my original version of the algorithm was wrong, that's why! :) I've fixed it. I don't know if it is any clearer. The basic idea is that the tests for points and quota are not independent; they follow the form: `$points > 2000*X && $quota < 15+X` [download] for some integer `0 < X < 10`. One can eliminate the redundancy between these two tests. Algebraically, the above is equivalent to `$points/2000 > X && X > $quota-15` [download] ...which can be further reduced to `$points/2000 + 15 > $quota` [download] ...except that there are edge cases (basically, `X` must be an integer strictly between 0 and 10) which make the algorithm a bit more complex. Read more... (1445 Bytes) the lowliest monk	[reply] [d/l] [select]
Re^4: alternatives to if and series of elsif by kiat (Vicar) on Jul 03, 2005 at 15:56 UTC
Great thanks, tlm! Now I understand how you got rid of $points > 2000. I was wondering how $new > $quota took care of everything. I ran gsiems's against your original version and it says "looks ok". Then then I tried to understand how your code works and that got me wondering about $new > $quota being a sufficient test. Cheers and thanks once again :)	[reply]