Re^3: Moving files

This is what i had at the beginning, at first it worked
because i was just moveing the files to another
folder on the c:, but when i start moveing
the files to a mapped drive all this started up so I tried
to rewrite it.


print "Enter the month and day (ex:0605)\n";
$date = <stdin>;
chomp($date);

move(c:/atmcaf00,K:/atm/atmcaf00$date);
move(c:/atmcaf00,K:/atm/atmcaf01$date);
move(c:/atmcaf00,K:/atm/atmcaf12$date);
move(c:/atmcaf00,K:/atm/atmcmf01$date);
move(c:/atmcaf00,K:/atm/atmcmf12$date);

print "All the ATM files have been renamed and move to the ATM folder\
+n";

$wait = <stdin>;
[download]

Comment on Re^3: Moving files Download Code

Replies are listed 'Best First'.
Re^4: Moving files by Nkuvu (Priest) on Jul 28, 2005 at 22:19 UTC
What I'm referring to is changing this code (extra blank lines removed for space considerations): `sub moving { print "Moving $_ to the K:/ATM \n"; move("$old$_","$new$_$date"); print "$_ has been moved to the K:/ATM\n"; print "---------------------------------------------\n"; } foreach (@files) { &moving; }` [download] into something more like: `foreach (@files) { print "Moving $_ to the K:/ATM \n"; move("$old$_","$new$_$date"); print "$_ has been moved to the K:/ATM\n"; print "---------------------------------------------\n"; }` [download] Personally I'd also use a named variable instead of `$_`, though, so I'd write something more like: `foreach my $file (@files) { print "Moving $file to the K:/ATM \n"; move("$old$file","$new$file$date"); print "$file has been moved to the K:/ATM\n"; print "---------------------------------------------\n"; }` [download] But changing `$_` to a named variable is not a functional change -- just makes the use of the loop variable a bit more clear.	[reply] [d/l] [select]

Replies are listed 'Best First'.

Re^4: Moving files
by Nkuvu (Priest) on Jul 28, 2005 at 22:19 UTC

sub moving {
    print "Moving $_ to the K:/ATM \n";
    move("$old$_","$new$_$date");
    print "$_ has been moved to the K:/ATM\n";
    print "---------------------------------------------\n";
}

foreach (@files) {
    &moving;
}
[download]

foreach (@files) {
    print "Moving $_ to the K:/ATM \n";
    move("$old$_","$new$_$date");
    print "$_ has been moved to the K:/ATM\n";
    print "---------------------------------------------\n";
}
[download]

$_

foreach my $file (@files) {
    print "Moving $file to the K:/ATM \n";
    move("$old$file","$new$file$date");
    print "$file has been moved to the K:/ATM\n";
    print "---------------------------------------------\n";
}
[download]

$_

[reply]
[d/l]
[select]