Re^2: getfile( $filename )

Yeah, I've run across that little ditty before, most recently as a yak shaving on my IPC::Open3 journey, but it doesn't handle wantarray. It just occurred to me that it doesn't chomp the lines either ... hmmm ...

  return wantarray ?
    do { my @lines = <$FH> ; chomp @lines ; @lines } :
    do { local $/ ; <$FH> };
[download]

I wish there was a way to chomp <$FH>.

Harley J Pig

Comment on Re^2: getfile( $filename ) Download Code

Replies are listed 'Best First'.
Re^3: getfile( $filename ) by merlyn (Sage) on Jul 29, 2005 at 03:55 UTC
I wish there was a way to `chomp <$FH>`. How about: `my @result = map /(.*)/, <$FH>;` [download] A teeny bit inefficient, but probably insignificant for anything but hammered code. -- Randal L. Schwartz, Perl hacker Be sure to read my standard disclaimer if this is a reply.	[reply] [d/l] [select]
Re^4: getfile( $filename ) by japhy (Canon) on Jul 29, 2005 at 12:31 UTC
Why not `my @result = map scalar(chomp, $_), <$FH>`? Jeff `japhy` Pinyan, P.L., P.M., P.O.D, X.S.: Perl, regex, and `perl` hacker How can we ever be the sold short or the cheated, we who for every service have long ago been overpaid? ~~ Meister Eckhart	[reply] [d/l]
Re^5: getfile( $filename ) by merlyn (Sage) on Jul 29, 2005 at 16:10 UTC
First, I wouldn't have expected scalar to take two arguments. True, modern perlfunc pages document this, but it's certainly unexpected to me. Second, I dislike modifying $_ in a map, because I believe a map to be applicative, not side-effect-ish. -- Randal L. Schwartz, Perl hacker Be sure to read my standard disclaimer if this is a reply.	[reply]
Re^5: getfile( $filename ) by harleypig (Monk) on Jul 29, 2005 at 18:03 UTC
I'm not sure how that works, but it seems like the map /(.*)/, <> is more perlish. Also, it's shorter. Harley J Pig	[reply]
Re^5: getfile( $filename ) by greenFox (Vicar) on Aug 03, 2005 at 07:55 UTC
Why not my @result = map scalar(chomp, $_), <$FH>? That use of scalar gives me the creeps! Isn't this equivalent and less obfuscated? `my @result = map {chomp; $_} <$FH>;` [download] Update: or for that matter whats wrong with `chomp(my @result = <$FH>);` -- Murray Barton Do not seek to follow in the footsteps of the wise. Seek what they sought. -Basho	[reply] [d/l] [select]
Re^4: getfile( $filename ) by harleypig (Monk) on Jul 29, 2005 at 07:55 UTC
Thanks! Updated. Harley J Pig	[reply]