in reply to Re^7: Self-testing modules
in thread Self-testing modules

In my experience the nasty bugs come, literally, from where I least expect them, and this is crucial. There is no hope that I will somehow write a test to catch such a bug, no matter how hard I try, because the best I can do is test those aspects that I regard as potential sources of problem. And in fact, during my recent applications of TDD, some very nasty bugs have arisen despite a rigorous adherence to TDD principles.

Of course I'm not saying that TDD guarantees zero bugs, no testing strategy can do that. However it's been my experience, and the experience of others, that TDD dramatically reduces the number of bugs.

However TDD is a skill, and it takes time to learn and get good at it. It took me a good few months before I really got it. Some of the mistakes that I made were:

What helped me grok TDD was dropping down to insanely small increments. Write the most obviously stupid non-general code to get the test to pass as quickly as possible. Then write a test to break that really stupid code.

(These bugs have all become manifest after the system had "aged" a bit and attained a particular—and as it turns out ill-conditioned—state; therefore, all the simple tests that tested functions to produce expected outputs missed these "history-dependent" bugs. I'm beginning to see that the functional programming folks are on to something with their avoidance of assignment and side effects.)

Since you're still getting a large number of nasty bugs my suspicion is that there are possibly some elements of TDD that you're missing.

Could you give a (small :-) code example that we could talk about that shows a bug that you missed during TDD?

Also, I find interesting the difference between your take on TDD and that described by Kent Beck in his widely cited TDD by Example. Beck uses "test first" only as a precondition for adding functionality to his software. I.e., he says that one should not write any new code in one's application until one has written a failing test that will succeed only after the new code has been written. He makes no mention of writing tests specifically designed to make the software fail.

It's the same thing from a different perspective.

If you're using TDD then every time you write a test you should expect that test to fail. It's the test failure that drives the design/development (hence the name :-)

With TDD you don't stop when all the tests pass, you stop when you can't write any more failing tests.

Replies are listed 'Best First'.
Re^9: Self-testing modules
by tlm (Prior) on Aug 02, 2005 at 02:48 UTC

    Could you give a (small :-) code example that we could talk about that shows a bug that you missed during TDD?

    I'm going to have to owe you that one for the time being, at least as far as code goes. There are three bugs I can think of. Probably the lamest happened with the code I just recently posted. I had a battery of around 40 tests already, all succeeding, when suddenly the test suite started seg faulting while setting up tests whose fixtures where very similar to those of earlier tests.

    To make a long story short, and much simpler than it appeared originally, the problem looked like this: 

    my %hash = map +( $_ => 1 ), ( 1..$reasonable );
my $it = Hash_Iterator->new( \%hash );
$hash{ $reasonable + $_ } = 1 for 1 .. $a_few_more;
$it->start;  # BOOM!

    [download]
    Basically, my code had not taken into account the fact that as hashes grow, perl will allocate more memory and move the (now overcrowded) entries to more spacious digs. When this happened, my iterator was left with a dangling pointer, leading to the seg fault. Shame on me for not thinking about this from the beginning, but my point is that this bug was there all along, but my "simple tests", testing simple things, one-feature-at-a-time, missed it entirely. As BrowserUk said, if the programmer writes his/her own tests he/she is bound to omit the tests that would make manifest the nasty bug; the same lapse that led to the bug, leads to the missing test.

    The hallmark of this and all other nasty bugs I've run into while doing TDD, is that they kick in only after a particular extended sequence of manipulations that leaves the system in a state not foreseen by the programmer. Typical TDD tests tend to miss these bugs, because these tests, necessarily, tend to have very short horizons. The more elaborate the sequence of steps to bring the system to an unsound state, the less likely that the unknowing programmer will think of writing any test that will bring on the problem. (Note that the tests that elicited the bug I just described were not expected to fail the way they did. I was testing something else entirely. It was just good luck that they picked up this problem.)

    This is a very interesting subject. I have been meaning to write a meditation/book review on TDDBE. I hope to give more details then, including, hopefully, some real code.

    I think that, as you say, I probably have not quite gotten the hang of TDD yet, which accounts for some of the problems I'm having with it. But I also think that the formulation of TDD given by Beck, which is the only one I know, has been dumbed-down beyond the point of usefulness. But this is a subject that deserves more time than I can give it now.

    the lowliest monk

[reply]
[d/l]

In Section Seekers of Perl Wisdom