Problem in parsing XML file using XMl::Twig

ramya2005 has asked for the wisdom of the Perl Monks concerning the following question:

I have the following two XML files.

books.xml

<Books>
   <Titles Mode="List">
    <Title Name="Programming Perl"/>
    <Title Name="Advanced Perl Programming"/>
    <Title Name="Learning Perl on Win32 Systems"/>
   </Titles>
</Books>
[download]

filter.xml

<Filters>
   <Titles>
    <Title Name="Programming Perl"/>
    <Title Name="Advanced Perl Programming"/>
    <Title Name="Learning Perl on Win32 Systems"/>
   </Titles>
</Filters>
[download]

I am trying to do the following using the code below.
1. Change the 'Title Name' in 'books.xml' by appending the existing 'Title Name' with some random number.
2. Change the corresponding 'Title Name' in 'filter.xml'

use XML::Twig;

# Learning XML testing functions
ReadBooksInfo('books.xml','filter.xml');

sub ReadBooksInfo{
   
   my $books_name  = shift;
   my $filter_name = shift;

   my $filter_tree;

   my $books_tree= new XML::Twig(
      TwigHandlers => { 
         Title => 
            sub { 

               my( $titletwig, $title_ele ) = @_;                     
+       my $titlename  = $title_ele->att('Name');                     
               my $unique_titlename = CreateUniqueFilterName($filterna
+me);
   
               print "\nGenerated unique title name:  ", $unique_title
+name; 
               print "\n";
   
               $title_ele->set_att( Name => "$unique_titlename ");
            
               $filter_tree= new XML::Twig(
                  TwigHandlers => {
                     qq[Title[\@Name="$titlename"]] =>
                        sub {
                           my ( $tree, $element ) = @_;

                           $element->set_att( Name => "$unique_titlena
+me" );
                           $element->print;
                        }
                  }
               );

               $filter_tree->parsefile($filter_name);

            }
      }
   );      

   $filter_tree->parsefile( $books_name );     
   $filter_tree->print;                        
   $books_tree->print;                      
}



# Create unique filter names
# ===========================
sub CreateUniqueFilterName { 
   
   my $user_filter_name    = shift;

   my $lower=1000; 
   my $upper=2000000; 
   my $random = int(rand( $upper - $lower + 1 ) ) + $lower; 
   
   my $unique_filter_name = $user_filter_name . "_". "$$". "_". "$^T" 
+. "_" .$random;

}
[download]

Now the problem is I am able to correctly parse the items. But at at the end when I print the 'books_tree - twig' only the Title name 'Learning Perl on Win32 Systems' reflects the changes. Everything else is same as the original books.xml file.

Please tell me how to fix this?

Comment on Problem in parsing XML file using XMl::Twig Select or Download Code

Replies are listed 'Best First'.
Re: Problem in parsing XML file using XMl::Twig by mirod (Canon) on Aug 16, 2005 at 22:55 UTC
Actually what should happen (I did not run the code) is that your program prints the modified element in `books.xml` for each title (from the `element->print` in the loop, then prints the entire `books.xml` resulting from the last loop, where indeed only 'Learning Perl on Win32 Systems' has been updated. What are you trying to do exactly? The example seems really contrived. In any case, your existing code processes `books.xml` and awfull lots of time (once per title)! If you really wanted to do this you should parse the first file, changing the titles and storing a hash `old_title => new title` (if memory is a problem you can use `twig_roots / purge` during the parse and tie the hash to a DBM file), then parse the second file, and replace each title found in the hash by the value (once again using `twig_roots / purge` if memory is tight). Does this help?	[reply]
Re^2: Problem in parsing XML file using XMl::Twig by ramya2005 (Scribe) on Aug 17, 2005 at 18:13 UTC
Thanks that tip helps!	[reply]
Re: Problem in parsing XML file using XMl::Twig by Roger (Parson) on Aug 16, 2005 at 21:48 UTC
What do you think `$$titlename` will interpolate as? It will give you the pid of the process + the text 'titlename'.	[reply] [d/l]
Re^2: Problem in parsing XML file using XMl::Twig by davidrw (Prior) on Aug 16, 2005 at 21:57 UTC
Actually it looks like `$$titlename` will dereference the scalar instead: `perl -wle 'use strict; my $bar = 3; my $foo = \$bar; print "$$foo"' # outputs: 3` [download] But OP probably doesn't want to use `$titlename` as a scalar ref .. so the line `qq[Title[\@Name="$$titlename"]] =>` should probably be: `qq[Title[\@Name="$$titlename"]] =>` [download] to OP: `use strict;` and `use warnings;` would have caught this saying something like `Can't use string ("MyTitleString") as a SCALAR ref while "strict refs" in use at foo.pl line 1234.`	[reply] [d/l] [select]
Re^3: Problem in parsing XML file using XMl::Twig by ramya2005 (Scribe) on Aug 16, 2005 at 22:28 UTC
I am sorry! That was a typo created when I copied the code and pasted it in Perl Monks editor. It is one $. And still the problem exists... But I realized that I am doing 'new' in a loop and that's why I am loosing the data. Can someone suggest me how to correct it? Is there a way to create new Xml::Twig and set the handler later? Thanks!	[reply]
Re^4: Problem in parsing XML file using XMl::Twig by davidrw (Prior) on Aug 16, 2005 at 22:35 UTC
Re^5: Problem in parsing XML file using XMl::Twig by ramya2005 (Scribe) on Aug 16, 2005 at 22:41 UTC