Re: Loop will not save into the array

I fancy that converting your code from

$stripped_html[$x] = join(" ",split " ",$stripped_html[$x]);
[download]

$stripped_html[$x] = join(" ",split(/\s+/,$stripped_html[$x]));
[download]

will do the trick. The reason being that if you have more than one white spaces, say, n, the split will generate n-1 undef's in the array, thus the warning.

Well, I would probably rewrite this using regular expression:

$stripped_html[$x] =~ s/\s+/ /g;
[download]

Comment on Re: Loop will not save into the array Select or Download Code

Replies are listed 'Best First'.
Re^2: Loop will not save into the array by graff (Chancellor) on Aug 18, 2005 at 05:05 UTC
Roger: If you read far enough down in "perldoc -f split", you'll find that `split " ",$string` and `split /\s+/,$string` are in nearly equivalent (except in how they treat initial whitespace in $string). Using a single quoted space character as the split pattern is one of those nifty little bits of perl magic that is meant to save unnecessary typing, giving the same behavior as a bare "split" call with no regex pattern. (But `split / /,$string` -- not using quotes -- really does split on every individual space character.) But I think you're right to suggest that the OP should add the extra parens, to make sure there's no confusion about which args are supposed to go to "split" as opposed to "join".	[reply] [d/l] [select]
Re^2: Loop will not save into the array by lampros21_7 (Scribe) on Aug 17, 2005 at 12:22 UTC
Thanks for your suggestion Roger. Unfortunately, it hasn't done the trick, it will still print the contents of the initial URL and then start giving the uninitialized value warning message. You forgot a ) after the regex in the $stripped_html... var (am mentioning this just to make sure you didn't do it for a special reason). I believe the problem is that for some reason the data will not be written in my two arrays but i can't understand why that is.	[reply]
Re^3: Loop will not save into the array by Roger (Parson) on Aug 17, 2005 at 12:46 UTC
Use `$website_links[0][0]` instead of `$website_links[0]`. Why? Because `$website_links[0]` is an array reference. Hang on, better still, you just need to change one line of code to make it work... From `my @website_links = $webcrawler->links;` [download] to `my @website_links = map { $_->[0] } $webcrawler->links;` [download] Cheers	[reply] [d/l] [select]
Re^4: Loop will not save into the array by lampros21_7 (Scribe) on Aug 17, 2005 at 13:51 UTC
Hi Roger, it still doesn't work. I have changed it to `my @website_links = map { $_-> [0] } $webcrawler->links;` and then in the while loop `@links = map { $_-> [0] } $webcrawler->links($new_uri[0]);` but it still gives the same error. Sorry about this! I havent mentioned that am using ActivePerl 5.8.7 Build 813 if this is going to get rid of some headaches. Thanks for the help.Lambros	[reply] [d/l] [select]