Maybe you mean diff -uFsub ? Diff -up seems to be 'c' code specific.

--- NodeBase.pm    2005-08-23 09:21:59.796875000 +0200
+++ NodeBase.pm.mod    2005-08-22 19:34:53.984375000 +0200
@@ -1963,9 +1963,10 @@ sub canCreateNode {
     my( $this, $USER, $TYPE )= @_;
     $TYPE = $this->getType( $TYPE );
 
+    my $writers= $TYPE->{writers_user};
     # The default is that everyone can create
-    return 1   if  ! $TYPE->{writers_user};
-    $this->isApproved( $USER, $TYPE->{writers_user} );
+    return 1   if  ! $writers;
+    return $this->isApproved( $USER, $writers, $TYPE );
 }
 
 
@@ -1974,14 +1975,15 @@ sub canDeleteNode {
     my( $this, $USER, $NODE )= @_;
     $this->getRef($NODE);
 
+    my $deleters= $NODE->{type}{deleters_user};
     # The default is that nobody can delete
-    return 0   if  ! $NODE  ||  ! $NODE->{type}{deleters_user};
+    return 0   if  ! $NODE  ||  ! $deleters;
 
     # -2 means "owner" can delete (anonymous?)
-    return $this->isApproved( $USER, $NODE->{author_user} )
-        if  -2 == $NODE->{type}{deleters_user};
+    return $this->isApproved( $USER, $NODE->{author_user}, $NODE )
+        if -2 == $deleters;
 
-    return $this->isApproved( $USER, $NODE->{type}{deleters_user} );
+    return $this->isApproved( $USER, $deleters, $NODE );
 }
 
 
@@ -2001,7 +2003,7 @@ sub canUpdateNode {
         $updaters = $NODE->{author_user};
     }
 
-    return $this->isApproved( $USER, $updaters );
+    return $this->isApproved( $USER, $updaters, $NODE );
 }
 
 
@@ -2013,14 +2015,16 @@ sub canReadNode {
 
     return 0   if  ! $NODE;
 
+    my $readers= $NODE->{type}{readers_user};
+
     # the default is that everyone can read
-    return 1   if  ! $NODE->{type}{readers_user};
+    return 1   if  !$readers;
 
     # -2 means only "owner" can read
-    return $this->isApproved( $USER, $NODE->{author_user} )
-        if  -2 == $NODE->{type}{readers_user};
+    return $this->isApproved( $USER, $NODE->{author_user}, $NODE )
+        if -2 == $readers;
 
-    return $this->isApproved( $USER, $$NODE{type}{readers_user} );
+    return $this->isApproved( $USER, $readers, $NODE );
 }
 
 
@@ -2032,25 +2036,28 @@ sub canReadNode {
 #       Checks to see if the given user is approved within a given gr
+oup
 #
 #   Parameters
-#       $user - reference to a user node hash  (-1 if super user)
-#       $NODE - reference to a nodegroup that the user might be in
+#       $USER  - reference to a user node hash  (-1 if super user)
+#       $GROUP - reference to a nodegroup that the user might be in
+#       $NODE  - optional reference to the item being tested against.
+#                its prescence allows rules to be applied against the
+#                the item.
 #
 #   Returns
 #       true if the user is authorized, false otherwise
 #
 sub isApproved

 {
-    my( $this, $USER, $NODE )= @_;
+    my( $this, $USER, $GROUP, $NODE )= @_;
 
-    return 0   if  ! $USER  ||  ! $NODE;
+    return 0   if  ! $USER  ||  ! $GROUP;
 
     return 1   if  $this->isGod($USER);
 
     my $user_id = $this->getId($USER);
     #you're always approved if it's yourself...
-    return 1   if  $user_id == $this->getId($NODE);
+    return 1   if  $user_id == $this->getId($GROUP);
 
-    foreach my $node (  @{ $this->selectNodegroupFlat($NODE) }  ) {
+    foreach my $node (  @{ $this->selectNodegroupFlat($GROUP) }  ) {
         return 1   if  $user_id == $this->getId($node);
         if(  $node->{type}{title} =~ /accessrule$/i  ) {
             my $res= eval $node->{code};
[download]

See my patch to MembersOnly, the first line shouldn't be needed so we should use:

            my $res= do {
                package Everything::HTML;
                eval $node->{code};
            };
[download]

I might be able to apply this and your changes today...

- tye        

An updated patch, incorperating above the previous changes a rewritten flattenNodegroup, minor tweaks to eliminate unnecessary calls to getRef() as well as the modifications discussed in the CB about isApproved() providing failure data in HTMLVARS. This patch is currently in use on the pmdev server. I used diff -uFsub to produce this patch.

Read more... (9 kB)
---
$world=~s/war/peace/g