in reply to Breakup user supplied text, whilst correctly ignoring HTML tags.

sub new { my ( $self, %supplied ) = (@_); my $class=ref($self) || $self; ...
ref($proto) - just say no!, says the bad-meme-killer.

-- Randal L. Schwartz, Perl hacker
Be sure to read my standard disclaimer if this is a reply.

  • Comment on Re: Breakup user supplied text, whilst correctly ignoring HTML tags.
  • Download Code

Replies are listed 'Best First'.
Re^2: Breakup user supplied text, whilst correctly ignoring HTML tags. (mini meme)
by tye (Sage) on Aug 25, 2005 at 05:59 UTC

    Wow, that's quite a knee-jerk reaction there.

    Much more important, IMO, is all of the manipulations of $self followed by return {}, $class; (throwing the modified $self away) or that $obj->new() modifies $obj or that 'use strict' only appears in the POD and some serious errors would be caught by its use.

    Steve, I'm guessing that the code you were using was a bit different than this (because I don't believe this code will set $width to anything but undef and so won't have much effect). Perhaps you wanted to 'dress it up' more like a complete module before posting it?

    The heart of the code looks good and useful. Thanks for posting it. And don't feel too bad about a few mistakes; we all make lots of mistakes.

    If you have any questions about the problems I outlined above, please reply and ask them.

    - tye        

      Thanks for the comment - which I only just noticed since it wasn't an immediate reply.

      You are correct the setup of the default width was broken. I didn't realise because I've always called it with an explicit width in my code, now I have a small test case collection which caught it.

      I'm not sure what more I can do to "dress it up" as you suggest - the core of the module is very simple, and I think it does all it needs to now. Still I'd certainly be interested in any concrete suggestions. As things stand it is working nicely upon my website and processing all the comment texts nicely ..

      Steve
      --