Re^4: Proposed new behaviour of isGods and isApproved (per session cache) ($NODE in key)

$NODE in key: 18 cache hits / 64 lookups
No $NODE in key: 62 cache hits / 64 lookups

In getting this test case ("node=re (patch)") I also noticed that %HTMLVARS is getting many large data structures left in it. So I'll add code to clean that up and deploy this weekend.

Sorry, I got started late tonight, so I skipped my stuff so I could at least give you some test results before the next "dry spell" of me sleeping and then doing my day job, and it's already an hour past when I should be asleep.

- tye

Comment on Re^4: Proposed new behaviour of isGods and isApproved (per session cache) ($NODE in key)

Replies are listed 'Best First'.
Re^5: Proposed new behaviour of isGods and isApproved (per session cache) ($NODE in key) by demerphq (Chancellor) on Sep 02, 2005 at 08:57 UTC
Ok, at first i was confused by this and now I realize you were looking at the results for the case where searching occurs. Im not sure if this is an ideal case to use for comparison tho. I believe that the search routine uses CanEditNode() is not normal. Try a normal page fetch and see the results there. I think the case where search isnt invoked is by far the more common case, so speeding that up is more important than speeding up search. Having said that obviously you have a point, but i think maybe there is a middle ground to be found where we still cache with node, but more intelligently. IE, if a group does not contain an accessrule then the NODE is not relevent. Anyway, food for thought. :-) Anyway, thanks for exploring this further, I will do more as well. --- $world=~s/war/peace/g	[reply]

Replies are listed 'Best First'.

Re^5: Proposed new behaviour of isGods and isApproved (per session cache) ($NODE in key)
by demerphq (Chancellor) on Sep 02, 2005 at 08:57 UTC

Ok, at first i was confused by this and now I realize you were looking at the results for the case where searching occurs. Im not sure if this is an ideal case to use for comparison tho. I believe that the search routine uses CanEditNode() is not normal. Try a normal page fetch and see the results there. I think the case where search isnt invoked is by far the more common case, so speeding that up is more important than speeding up search.

Having said that obviously you have a point, but i think maybe there is a middle ground to be found where we still cache with node, but more intelligently. IE, if a group does not contain an accessrule then the NODE is not relevent. Anyway, food for thought. :-)

Anyway, thanks for exploring this further, I will do more as well.

---
$world=~s/war/peace/g

[reply]