Re^3: File::Slurp bug? Should I bother?

Disk size:            21

Inlined, binmode:     21
Slurp,   binmode:     21

Inlined, not binmode: 18
Slurp,   not binmode: 21

Slurp:                21


Slurp is different from inlined version.
[download]

C:\>perl -MFile::Slurp -le "print $File::Slurp::VERSION"
9999.09

C:\>perl -v

This is perl, v5.8.6 built for MSWin32-x86-multi-thread
(with 3 registered patches, see perl -V for more detail)
[download]

Blarg, OK, this may be a problem with sysread.

use strict;
use warnings;

use Fcntl qw{:DEFAULT};
use Data::Dump qw{dump};

sysopen my $FILE, 'file', O_RDONLY or die $!;

my ($temp, $buf);

while(1) {
    my $read_cnt = sysread ($FILE, $temp, 1024);
    $buf .= $temp;
    last unless $read_cnt;
}

print dump($buf);
[download]

This gives me the faulty newlines. I think this is a bug in my Perl build. Google turned up some (vague) results to that effect. I assume sysread is supposed to do CRLF translation to \n, just like <>? I checked, and the layers in effect on this filehandle are ("unix", "crlf"). Should be working.

Comment on Re^3: File::Slurp bug? Should I bother? Select or Download Code

Replies are listed 'Best First'.
Re^4: File::Slurp bug? Should I bother? by ikegami (Patriarch) on Sep 07, 2005 at 18:12 UTC
I just experimented a little using `This is perl, v5.6.1 built for MSWin32-x86-multi-thread` `->` sysread convert CRLF to LF. `This is perl, v5.8.0 built for MSWin32-x86-multi-thread` `->` sysread does not convert CRLF to LF. Both are ActiveState builds. Apparently, sysopen/sysread's behaviour changed in 5.8 wrt to CRLF conversion. It used to convert, but now it doesn't. I don't see this mentioned in Perl 5.8's perldelta or anywhere else. It seems to be an (unintentional?) side-effect of switchting to PerlIO.	[reply] [d/l] [select]
Re^5: File::Slurp bug? Should I bother? by chester (Hermit) on Sep 07, 2005 at 18:30 UTC
Ah, it seems to be mentioned for Perl 5.8.1. (Although the text does reference 5.8.0; beats me...) "As of the 5.8.0 release, sysopen()/sysread()/syswrite() do not behave like they used to in 5.6.1 and earlier with respect to "text" mode. These built-ins now always operate in "binary" mode (even if sysopen() was passed the O_TEXT flag, or if binmode() was used on the file handle). Note that this issue should only make a difference for disk files, as sockets and pipes have always been in "binary" mode in the Windows port. As this behavior is currently considered a bug, compatible behavior may be re-introduced in a future release. Until then, the use of sysopen(), sysread() and syswrite() is not supported for "text" mode operations.' I'm glad to know why it's broken, even if it means no File::Slurp. Thanks for all the help. I wonder if they plan to fix that any time soon. There's a bug report at ActiveState from 2003.	[reply]