Re^2: 'Variable' sub names

You missed something. Your script produces Useless use of hash element in void context. You need to use $subs{$product}->().

#!c:\perl\bin\perl.exe -w

use strict;
use warnings;

my @products = qw (prod1 prod2);

my %subs = (    
    prod1    => \&sub_prod1,
    prod2    => \&sub_prod2
);

foreach my $product (@products) {
    $subs{$product}->();
}

sub sub_prod1 {
print 1;
}

sub sub_prod2 {
print 2;
}
[download]

Comment on Re^2: 'Variable' sub names Select or Download Code

Replies are listed 'Best First'.
Re^3: 'Variable' sub names by svenXY (Deacon) on Sep 15, 2005 at 13:39 UTC
Hi, or so: `foreach my $product (@products) { &{$subs{$product}}; }` [download] then one can see better that it is a sub call. Regards, svenXY	[reply] [d/l]
Re^4: 'Variable' sub names by Fletch (Bishop) on Sep 15, 2005 at 13:48 UTC
Keep in mind that your example will call the coderef in `$subs{$product}` with the current contents of `@_` just as if you'd called `&namedsub;`. If you want to pass an empty argument list you still need the parens: `&{ $subs{ $product } }( )`. See `perldoc perlsub` for more details.	[reply] [d/l] [select]
Re^4: 'Variable' sub names by revdiablo (Prior) on Sep 15, 2005 at 17:01 UTC
then one can see better that it is a sub call Perhaps one (since you count as one, I presume) can better see that, but I would think the general Perl-using population understands `$foo->()` to be a subref call. And even if I'm wrong about that, well, I just think it looks better. :-)	[reply] [d/l]
Re^4: 'Variable' sub names by merrymonk (Hermit) on Sep 15, 2005 at 16:13 UTC
Many thanks both work well.	[reply]