Re: grouping lines of data together for later use

Huh?!? I don't have time to read your code carefully now, but I'm not really sure you're under strict, although you do use my. OTOH there are long, too long IMHO, lists of "non my'ed" vars and all in all I find it hardly readable.

So, if you're not under strict (and warnings), please do!!

Said this, judging from your subject & description, as of the queek peek I gave into it, the obvious, mandatory quick answer would be: hashes. Since I don't seem to see any in your code chances are that it could be the correct one.

Check perldata for more info.

Update(taking into account your {reply,remark}):

open PAGE, "$website" or die "Cant open $website: $!"; flock (PAGE, 1) or die "Can't lock website file for reading";
[download]

The usual recommendation about three arga form of open and lexical FHs apply. Also, always include $! in {error,warning} messages about failed system calls.

while (my $line = (<PAGE>)) { ($Prop,$colour,$txtcol,$url360,$user,$your_name,$address,$town,$zip_co +de,$country,$email,$telephone_no,$telephone_no2,$theme,$web_address,$ +ppemail,undef,undef,undef) = split "\t", $line; #create array of users and hash of data $onprop{$Prop} = [$Prop,$colour,$txtcol,$url360,$user,$your_name,$ +address,$town,$zip_code,$country,$email,$telephone_no,$telephone_no2, +$theme,$web_address,$ppemail]; push (@dataarray, $user); }
[download]

Commented this here.

while (<@dataarray>) {
[download]

Huh?!? This works, if it does work, by accident, only because probably glob doesn't do anything on those items...

unless (! $item) {
[download]

How 'bout

        if ($item) { ...
[download]

And it's largely a matter of personal preferences, but how 'bout

        next unless $item;
[download]

instead?

And so on...

Comment on Re: grouping lines of data together for later use Select or Download Code

Replies are listed 'Best First'.
Re^2: grouping lines of data together for later use by jonnyfolk (Vicar) on Sep 27, 2005 at 12:24 UTC
Thanks for the quick answer - I can see you neither had time to read the code or the question (you'll see the quick answer doesn't really fit :) ) I should probably have mentioned (but didn't think to) that this is an excerpt from a larger script which does work under strict, is properly declared and if you take a closer look you'll see a hash staring right back out at you!! As I also mentioned it does do the job I require, but I'd like an opinion from fellow monks as I'm not well skilled at this sort of thing. Cheers Update: I appreciate your further comments and will try to implement and learn for future use. Thanks very much.	[reply]
Re^3: grouping lines of data together for later use by blazar (Canon) on Sep 27, 2005 at 12:50 UTC
I should probably have mentioned (but didn't think to) that this is an excerpt from a larger script which does work under strict, is properly declared and if you take a closer look you'll see a hash staring right back out at you!! Sorry. Now I see. Indeed that long list of variables is mostly confusing (to me). To increase readability you may either use a list slice, and optionally put it into a temporary array: since you know which are the fields you're interested in in any case, you can access the (few) ones you want to use as "keys" by numeric subscript and the (many) other ones like aggregates or turn those variables into hash(ref) keys (thus possibly adopting a more complex, but easier to deal with data structure) hopefully specified with more whitespace to increase readability instead. As an example of the second point I mean something like (but modify at will): `while (<$page>) { my %localprop; @localprop{ qw(Prop colour txtcol url360 user your_name address town zip_code country email telephone_no telephone_no2 theme web_address ppemail) } = split /\t/; $onprop{ $localprop{Prop} } = \%localprop; push @dataarray, $localprop{$user}; }` [download] As I also mentioned it does do the job I require, but I'd like an opinion from fellow monks as I'm not well skilled at this sort of thing. Well, a suggestion is above, and the proposed code -although it may not be exactly what you need- is IMHO much less of a mess than the original one...	[reply] [d/l]