in reply to Cleaning the Monastery dishes

Pfaugh. 
mess:

$dishesFactory = DishesFactory->instance; # singleton

Sendmail->send( $dishesFactory, "I need clean dishes" );

@dishes = $dishesFactory->get;

use @dishes;

DESTROY @dishes;

sleep until next $mealtime;

goto mess;

[download]

Replies are listed 'Best First'.
Re^2: Cleaning the Monastery dishes
by GrandFather (Saint) on Oct 03, 2005 at 21:38 UTC

    We tell the children and we tell the children: use strict; use warnings;.

    Just adding a comment does not a singleton make, and if it is a singleton why do you need an assignment inside the loop?

    Is there not a send member on the DishesFactory object? If you use the asynchronous get member there is no need to use the send member. Indeed the send member should only be used for reporting failed gets.

    use @dishes; is simply an error. I think you intended $Monks->use (@dishes);

    DESTROY @dishes; is a syntax error. Use @dishes = ();

    sleep until next $mealtime; is just hoplessley confused. The following would be appropriate:

    my $nextMealTime = $mealTime->next ();
sleep (60) while (time < $nextMealTime);

    [download]

    And finally, there is absolutly no need for a goto. you could use {...; redo;} instead, but there are many other options (see here).

    Very poor marks for this effort I'm affraid. Try harder next time, we know that you can do better than this.

    Perl is Huffman encoded by design.
[reply]
[d/l]
[select]
      You need to lighten up.
[reply]

        This whole tread is "light". Don't take it to heart so or you'll be put on KP while your script is being sorted out :).

        Perl is Huffman encoded by design.
[reply]
Re^2: Cleaning the Monastery dishes
by serf (Chaplain) on Dec 08, 2005 at 11:44 UTC
    Huh? 
    DESTROY @dishes;

    [download]
    It's all Greek to me!
[reply]
[d/l]

In Section Cool Uses for Perl