s/// not replacing data

Anonymous Monk has asked for the wisdom of the Perl Monks concerning the following question:

In somewhat regards to my SOPW yesterday, I am having problems applying a swear filter to some text.

When I test print '$badword' it prints a list like

'badword1'
'badword2'
'badword3'
and so on
[download]

So I know the retrieved words are correct. I've done plenty of test prints to see what's going on throughout this process. I am thinking it has something to do with the s/// itself beacause it doesn't catch on- anywhere.

# @keep has all the messages in it.
# @keep_after_swear_words should be the filtered version of @keep

my $data = qq(SELECT id, word FROM swears);
my $sth = $dbh->prepare($data);
$sth->execute() or die $dbh->errstr;

my ($id, $badword);
$sth->bind_columns(\$id, \$badword);

foreach my $line (reverse @keep)
{
   my ($username, $message, $date, $ip) = split(/<!!>/, $line);
         #print "user: $username<br> message: $message<br> date: $date
+<br> ip: $ip<br><br>";
   while ($sth->fetch)
   {
      $username =~ s/\b$badword\b/ **** /gi;
      $message =~  s/\b$badword\b/ **** /gi;
   }
     print "message: $message<br>";
      push(@keep_after_swear_words, "$username<!!>$message<!!>$date<!!
+>$ip");
}

#.. print out modified text here
[download]

Can anyone possibly see why this swear filter isn't catching words?

Comment on s/// not replacing data Select or Download Code

Replies are listed 'Best First'.
Re: s/// not replacing data by Roy Johnson (Monsignor) on Oct 31, 2005 at 16:21 UTC
What are you `$sth->fetch`ing, and why are your substitutions in that loop? If that doesn't yield anything, the calls to s/// aren't going to happen. Caution: Contents may have been coded under pressure.	[reply] [d/l]
Re^2: s/// not replacing data by Anonymous Monk on Oct 31, 2005 at 16:28 UTC
The fetch is to retrieve the swearwords from the database. It does it because I can print out the swearwords. The process is like this: 1) All the chat info (name, message, ip, time) is retrieved from the DB and placed into an array @keep. 2) The list of my swear words are fetched and applied to the data above. This is pushed into the new array @keep_after_swear_words. 3) The emoticon filters then optimizes the swear-filtered data and applies it's last filter 4) The text is then printed to screen.	[reply]
Re^3: s/// not replacing data by VSarkiss (Monsignor) on Oct 31, 2005 at 16:38 UTC
That's not what you're doing. You run thru your list of swear words only once, applying it to the first line in `@keep`. If you intend to apply every substitution to every chat line, you need to either re-fetch the data, or, if there's not that many of them, keep them in memory. Do not rebuke them with harsh words ... but rather lead them gently - with URLs - so that they may learn wisdom.	[reply] [d/l]
Re^4: s/// not replacing data by sulfericacid (Deacon) on Oct 31, 2005 at 16:43 UTC
Re^5: s/// not replacing data by VSarkiss (Monsignor) on Oct 31, 2005 at 16:51 UTC
Some notes below your chosen depth have not been shown here
Re^3: s/// not replacing data by davido (Cardinal) on Oct 31, 2005 at 16:34 UTC
Yes, but how are you assigning the results of $sth->fetch() to $badword? That seems to be missing. Perhaps $badword is never being populated. You can test this by putting a `print "$badword\n";` into your `while` loop. Dave	[reply] [d/l] [select]
Re^4: s/// not replacing data by japhy (Canon) on Oct 31, 2005 at 16:39 UTC
Re^5: s/// not replacing data by davido (Cardinal) on Oct 31, 2005 at 16:41 UTC
Re^4: s/// not replacing data by VSarkiss (Monsignor) on Oct 31, 2005 at 16:42 UTC
Re^5: s/// not replacing data by davido (Cardinal) on Oct 31, 2005 at 16:46 UTC
Re^4: s/// not replacing data by Anonymous Monk on Oct 31, 2005 at 16:41 UTC
Re^5: s/// not replacing data by Roy Johnson (Monsignor) on Oct 31, 2005 at 17:05 UTC
Re^4: s/// not replacing data by Anonymous Monk on Oct 31, 2005 at 17:10 UTC
Re^5: s/// not replacing data by Roy Johnson (Monsignor) on Oct 31, 2005 at 17:30 UTC
Re: s/// not replacing data by stonecolddevin (Parson) on Oct 31, 2005 at 21:41 UTC
Regexp::Common has a feature for filtering out swear words. meh.	[reply]