Re^2: PERL Warnings

ok, im working through some of the warnings, and i have a question. is this not valid:

    my ($sec,$min,$hour,$mday,$mon,$year,$wday,$yday,$isdst)=localtime
+(time);
    my $dateTime = $hour,":",$min,":",$sec," ",$mday,"/",$mon+1,"/",$y
+ear+1900,"";
[download]

when i run my program, i get this for output:
Useless use of a constant in void context at C:\Perl\test\Dev\AutoSI\autoSI.pl line 98.
Useless use of private variable in void context at C:\Perl\test\Dev\AutoSI\autoSI.pl line 98.
Useless use of a constant in void context at C:\Perl\test\Dev\AutoSI\autoSI.pl line 98.
Useless use of private variable in void context at C:\Perl\test\Dev\AutoSI\autoSI.pl line 98.
Useless use of a constant in void context at C:\Perl\test\Dev\AutoSI\autoSI.pl line 98.
Useless use of private variable in void context at C:\Perl\test\Dev\AutoSI\autoSI.pl line 98.
Useless use of a constant in void context at C:\Perl\test\Dev\AutoSI\autoSI.pl line 98.
Useless use of addition (+) in void context at C:\Perl\test\Dev\AutoSI\autoSI.pl line 98.
Useless use of a constant in void context at C:\Perl\test\Dev\AutoSI\autoSI.pl line 98.
Useless use of addition (+) in void context at C:\Perl\test\Dev\AutoSI\autoSI.pl line 98.
Useless use of a constant in void context at C:\Perl\test\Dev\AutoSI\autoSI.pl line 98.
anyhelp would be great. thanks

Comment on Re^2: PERL Warnings Download Code

Replies are listed 'Best First'.
Re^3: PERL Warnings by Tanktalus (Canon) on Nov 21, 2005 at 21:15 UTC
You should probably log back in when you post a follow-up. Anyway, no, it's not valid. Try changing all the commas to dots: `my $dateTime = $hour.":".$min,":".$sec," ".$mday."/".$mon+1."/".$ye +ar+1900."";` [download] Or you can change $dateTime to @dateTime, and put the whole RHS in parenthesis: `my @dateTime = ($hour,":",$min,":",$sec," ",$mday,"/",$mon+1,"/",$y +ear+1900,"");` [download] Of course, doing that changes how you use it as well. I'm guessing you want the first one. Note that you may also just find it easier to use sprintf: `my $dateTime = sprintf "%02d:%02d:%02d %02d/%02d/%d", $hour, $min, $sec, $mday, $mon+1, $year+1900;` [download] PS - I'm not sure why you have that ending empty string - you should be able to get rid of it.	[reply] [d/l] [select]
Re^3: PERL Warnings by sgifford (Prior) on Nov 21, 2005 at 21:15 UTC
Well, run it and see if `$dateTime` is set to what you expect. On my system, it's set to `16`, which is probably not what you expect. The comma seperates arguments to a function, or if not used in a function call, executes all of the statements listed. In this case, it's first executing: `my $dateTime = $hour` [download] then `":"` [download] then `$min` [download] Neither `:` nor `$min` will do anything, so Perl complains this probably isn't what you wanted. Probably you meant to use the dot operator (`.`) to concatenate these together as strings, or else use the strings as arguments to `join`.	[reply] [d/l] [select]