Re^4: array processing

You can even do the uniqe test using grep as you add items. This is also a wasteful approach but maybe easier on memory usage if the log file that you are processing is large.

    if ($line =~ /Login succeeded. User: (\w+)/i) {
        my $user = $1;
        push @users, $user unless grep (/$user/i, @users);
    }
[download]

Using a hash is the best plan.

Comment on Re^4: array processing Download Code

Replies are listed 'Best First'.
Re^5: array processing by tirwhan (Abbot) on Dec 06, 2005 at 11:55 UTC
Well, that's a lot more wasteful IMO, because you're grepping the entire array every time you find a login line. You're right that the resulting array never grows to the size it does in my last post, but unless you only have a handful of user who log in extremely often (like tens of thousands of times) I would say this is a bad idea. Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it. -- Brian W. Kernighan	[reply]

Replies are listed 'Best First'.

Re^5: array processing
by tirwhan (Abbot) on Dec 06, 2005 at 11:55 UTC

Well, that's a lot more wasteful IMO, because you're grepping the entire array every time you find a login line. You're right that the resulting array never grows to the size it does in my last post, but unless you only have a handful of user who log in extremely often (like tens of thousands of times) I would say this is a bad idea.

Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it. -- Brian W. Kernighan

[reply]