in reply to Perl project lines of code "analyzer"

I would consider replacing

push @files, $File::Find::name if $ext eq $_;

with

push @files, $File::Find::name if( $ext and $ext eq $_ );

in order avoid potential uninitialized value warnings.

<a href="http://www.graq.co.uk">Graq</a>

Replies are listed 'Best First'.
Re^2: Perl project lines of code "analyzer"
by psychotic (Beadle) on Dec 20, 2005 at 19:19 UTC
    Updated to: 
    $ext and push @files, $File::Find::name if $ext eq $_;

    [download]
    Thanks for the tip! Working mostly on windows, i often forget that files may not have a type extension in other systems. Regards.
[reply]
[d/l]

      Where you have...

              my $fname = $_;
        if (-f $fname) {
            foreach my $type (qw(pl pm)) {
                my (undef, $ext) = split (/\./, $fname);
                if (defined($ext) && $ext eq $type) {
                    push(@files, $File::Find::name);
                }
            }
        }

      [download]

      It would be better to instead have...

              my $fname = $_;
        if (-f $fname && /\.p(l|m)$/) {
            push(@files, $File::Find::name);
        }

      [download]

      ...or so I believe. The reason I changed my own copy to this is that I have scripts with the version number at the end like so...

      Frans_Perl_Program.1.5.1.pl

      ...when I am working on something by stages.

[reply]
[d/l]
[select]

In Section Code Catacombs