Re: Blocking based on words in a list

chomp for @blocked; # don't expect to match newlines
if ( grep { $FORM{'comments'} =~ /\b$_\b/ } @blocked) {
  ...
}
[download]

This is somewhat simplistic, not to mention inefficient - the grep continues over every word in the list even if the first word matches. A better approach would use a for loop:

chomp for @blocked;
for my $m (@blocked) {
  if ($FORM{'comments'} =~ /\b$m\b/) {
    # print your message here.
    exit;  #  could also last outside the loop
  }
}
[download]

The \b markers are to match at a word boundary, so BLOCK will not be matched in THIS SHOULD BE UNBLOCKED, for example.

However you may want to re-think your approach. Simplistic blockers like this rarely achieve the desired results, and often produce too high a level of false positives to be truly useful. YMMV, of course.

Comment on Re: Blocking based on words in a list Select or Download Code

Replies are listed 'Best First'.
Re^2: Blocking based on words in a list by VSarkiss (Monsignor) on Dec 28, 2005 at 02:28 UTC
A tangential note regarding the construct you used twice: `chomp for @blocked;` [download] The `for` is unnecessary. chomp over a list will chomp every element, so you can just say: `chomp @blocked;` [download] to get the same result. More info at perlfunc. Do not rebuke them with harsh words ... but rather lead them gently - with URLs - so that they may learn wisdom.	[reply] [d/l] [select]
Re^2: Blocking based on words in a list by strat (Canon) on Dec 28, 2005 at 08:35 UTC
`$FORM{'comments'} =~ /\b$_\b/ }` [download] That may give errors or unexpected behaviour if there are metachars for REs in @blocked (e.g. opening parantheses, dots, ...). Either use quotemeta for each $_, or \Q$_\E, e.g. `@blocks = map { quotemeta($_) } @blocks; ... $FORM{'comments'} =~ /\b$_\b/` [download] `$FORM{'comments'} =~ /\b\Q$_\E\b/` [download] Best regards, perl -e "s>>F>e=>y)\martinF)stronat)=>print,print v8.8.8.32.11.32"	[reply] [d/l] [select]