Every twenty four hours the trash bags are dumped. Then anything in the deleted folder is moved into the trash bag. This way you have at minimum twenty four hours to undelete, and at maximum 48. I could have called them "soon to be dumped" and "recently deleted" or something like that, or even not shown any difference to the user, but I didnt.

The other two issues ill look into, but you could just as easily post a patch. :-)

BTW, search criteria apply to moves/deletes. So if you have a private chat with someone you can just filter on their name and then choose "unselected" and "(deleted)" and hit submit and all the ones you can see will be deleted. This is also useful for removing replies from root in bulk or whatever.

Ok, I propose the following.

First, who is going to submit a search at the same time as they’re moving some individual items to arbitrary folders and a group of others to yet another place? Allowing that sort of multiple action just forces the user to consider every single control on the page (all belonging to several distinct actions) for every single action he takes. Awful. The whole thing needs to be broken out into several independent forms.

1. Folders need to be listed as clickable links on the left-hand side, with the count of messages in the respective folder included on the label. The currently selected folder should be highlighted and not linked.

2. The search stuff needs to be a completely separate from. Preferrably should go at the bottom, I think. Default the folder to “(all)”, since that’s what most people are probably likely to want when they do a search. Instead of the [From | To | From/To] dropdown, put two checkboxes. Comboboxes are the least usable UI control by far; avoid whenever possible.

   Update: search in deleted messages only when the user explicitly asks for that.

3. When showing search results from all folders, no folder should be selected; or maybe show a virtual “Search Results” folder. In that view, put the search controls at the top so they’re easier to reach when the user inevitably goes to refine his/her search.

4. Untangle the message input box from the target selection. The current setup is

   Send to:
     * User: [_____]
   Nobody  Reply text:
     *  [________________]
   Reply to:
     * Foo says Blah
     * Bar says Blah
   

   Instead it should be

   Message: [________________]
   
   Send to:
     * Nobody
     * User: [_____]
   Reply to:
     * Foo says Blah
     * Bar says Blah
   

   A nice touch for those with JS enabled would be to auto-select the “User” checkbox when the attached entry gets changed to something non-empty. Actually now that I look at the new arrangement I wonder why there needs to be a “Nobody” option at all; sending to a blank username would accomplish the same.

5. Move/delete:

   • Put the controls on the right side in the replies table, lined up with the checkboxes.

   • Lose the Folder dropdown box for individual messages, since it adds a huge amount of visual clutter and only benefits the people who have a significant number of folders and frequently file many different messages into many different of these folders at once. I can’t imagine that being such a large fraction of the userbase that it’s worth degrading the page’s skimmability for everyone else.

     Update: the only other case where these dropdowns matter is when doing a search that picks up results from multiple folders. So group search results by folder.

   • To preserve the “apply actions to the results of a search” functionality, you can add the search parameters as hidden fields to the reply form.

6. Update: lose the “(deleted)” vs. “(trash-bag)” distinction. Just show how much time messages have left till irreversible deletion.

Makeshifts last the longest.

Default the folder to “(all)”, since that’s what most people are probably likely to want when they do a search.

I thought the same, but then I saw it also shows deleted messages. I don't want to see those by default.

Also: the link to message inbox from the Chatterbox Nodelet and Fullpage Chat links to the Archive. I don't want that, but it's the only link to the message inbox on those places. I rarely, if ever, look at archived messages. I just want an easier interface to continue a conversation in private. That's not what I get now.

I agree with much but not all these ideas.

The CB now always links to both "new msgs" and "archived msgs" (and /looks like/ two links -- the previous links ran together).

I'm more convinced of my previous stance that the drop-down 'destination' controls should go. I'd like the "all but" checkbox I asked for and a simple "Delete" button and a "Move to" button w/ a drop-down list of other folders (we could also just make a button for each folder, but I think that would be less clear).

I'd rather the forms stay at the top (imagine viewing 500 msgs, which I sometimes do) but think that having a 'sticky' state that hides or shows the 'search' form (which should be a separate form) would be nice.

"Nobody" is there (in part) because neither the "send to" nor "message text" fields get cleared when you submit to facilitate sending similar messages to multiple people, coping with addressing errors, sending multiple messages to one person, etc. And w/o "Nobody" (which is /always/ what is selected when the form is refreshed), it becomes /way/ too easy to accidentally send more than you wanted to (and the "whoa cowboy" duplicate message check will only catch fairly fast exact duplicates).

We really need a prominent warning if you submit with non-empty message text but "Nobody" selected, because this is now the mistake that is /way/ too easy to make.

But, with the warning, the correction (select a destination and submit again) is trivial. With the common mistake being "send when I didn't intend to", the "correction" isn't pretty.

I'd eventually like the "/msg author" links to use a different page that is better suited for just sending private messages (and uses a better method for preventing unintended repeats).

I'd not put so much separation between "Message:" and "Send to:", more like:

   Send: [.......]
   To:
    * Nobody
    * [....]
   In reply to:
    * ...
[download]

Much thanks to demerphq for putting this together. There is more work to be done to smooth out the interface, but I think it will come together well, especially if people pitch in with patches.

- tye        

First, who is going to submit a search at the same time as they're moving some individual items to arbitrary folders and a group of others to yet another place? Allowing that sort of multiple action just ....

The combination is absolutely required. I want to be able to search for messages based on a set of criteria and then organzie them into folders. Not allowing that sort of multiple action means that I wouldnt be able to do that. Which would defeat the whole purpse of this patch.

To rephrase: the idea is that you can select a set of criteria to find some messages and then have the ability to move them around as needed. If you can't combine the various parts then you have severly crippled the implementation. What good is it to me to be able to find a bunch of nodes but not be able to do something useful with them?

Some responses:

1. No it doesnt. That would take up too much room. People can have up to 99 different folders if they like. How do you plan to fit them all on one line.
2. Its possble ill remove the from/to option and maybe change it to some other control. I'm not aware of why you say "Comboboxes are the least usable UI control by far; avoid whenever possible." Seems to me to be a good way to avoid confusion as it shows only the option selected and doesnt distract with the options not selected.
3. No comment. You don't seem to have grasped that _every_ view of the message inbox is a "search" of some sort. You _can't_ seperate the action of searching from the action of viewing a folder as thats how the latter is accomplished.
4. Patches welcome.
5. I might change the drop down folder. I might just add a delete radio button so folks with not so many messages don't need to use it. But your claim that this feature cant be useful IMO is not correct, I find it useful, in fact I wrote it because sorting out my inbox without it was proving to be incredibly annoying. And again regarding your comment about "apply actions to the result of the search", any view of your inbox is a result of a search.
6. Yes i might lose the distinction between "trash" and "deleted". But there is no way to show how long a message has until irreversible deletion. The script is unaware of the logic that controls the deletion and only knows the "state" of the record. (FYI -3 is "user cant see the node as its deleted", -2 is "trash-bag", -1 is "deleted", 0 is "general/inbox", 1 is Archived, 2+ are user defined. This value is stored for both the sender and the receiver. When the record is in state -3 for both it is actually deleted.

Anyway, you are pmdev, put together some patches that you think improves the situation, and if they don't impact on what i feel are the requirements then ill put them into play. So lets see your improvements as a patch ok?

update: I'd like to add that I realize my comments above might sound a little testy. If so im sorry, I appreciate the time you took to feedback, and Ill do what I can with the time I have to smooth out some of the rough edges. But patches would be appreciated as they are a lot easier to evaluate than text descriptions or little ascii pictures are. (Not to say diagrams and descriptions arent useful, just patches are more so.) For all I know I've misunderstood some of your points anyway, which would be pretty difficult with code.

---
$world=~s/war/peace/g

Ive done some tweaking of the UI for the inbox. I hope that some of your concerns are resolved now. Please post any patches to demerphq's sandpit, not to the inbox, as the sandpit is where they will get tested before they go to the inbox.

That looks much nicer, though it’s not quite there yet IMHO.

Concerning patches: I thought I’d poke and prod it on the dev server and post patches to the regular inbox once I’m done. Not good?

Makeshifts last the longest.

If you could give me feedback on demerphq's sandpit id be obliged. If added a "simple mode" and changed the layout in a way that hopefully you will find more intuitive.

As for the pmdev server im not sure. Its possible that the code here will run there ok, is fairly out of synch right now.

---
$world=~s/war/peace/g