in reply to Re^4: Announcing Perl-Critic-0.14
in thread Announcing Perl-Critic-0.14

Conclusion: Always assign something in a my declaration?

More precisely: make sure an assignment with a my on the left-hand side is never conditional.

Makeshifts last the longest.

Replies are listed 'Best First'.
Re^6: Announcing Perl-Critic-0.14
by diotalevi (Canon) on Jan 30, 2006 at 21:08 UTC

    It's not about the assignment. It's that my() should never be conditional. my $foo if $bar is just as bad for the same reason. You're just not likely to write that because it looks funny. my $foo ... for ... is probably also just as bad. The statement modifier form allows the my() to declare the variable for use by all following statements in that scope.

    ⠤⠤ ⠙⠊⠕⠞⠁⠇⠑⠧⠊