Do you have a good suggestion for the "almost perfect" solution?

Could you point me in the right direction about what I'm doing wrong in the current function? I know I'm doing something wrong, but I think I've managed to blindfold myself while looking at the problem...