Re: Whitespace issues in testing

You really need a domain parser. For example, your SQL looks like:

create table foo (
  id INTEGER       NOT NULL PRIMARY KEY,
  name VARCHAR(32) NOT NULL,
  age integer
);
[download]

My version would look like:

create table foo (
  id INTEGER       NOT NULL PRIMARY KEY
 ,name VARCHAR(32) NOT NULL
 ,age integer
);
[download]

What you really want is Test::SQL, not Test::ControlWhitespace.

My criteria for good software:

Does it work?
Can someone else come in, make a change, and be reasonably certain no bugs were introduced?

Comment on Re: Whitespace issues in testing Select or Download Code

Replies are listed 'Best First'.
Re^2: Whitespace issues in testing by jhourcle (Prior) on Feb 28, 2006 at 14:49 UTC
Some people would argue that defining a primary key to be 'NOT NULL' is redundant as well, so a statement without it should be considered the same. (I'm not sure if that's a function of the database, though, which might introduce extra complexity). PS. back when I took Oracle's SQL Tuning class (back in 2001 or so), we were told that the caching only worked for exact string matches -- any whitespace or capitalization changes would be considered a different query to the optimizer.	[reply]

Replies are listed 'Best First'.

Re^2: Whitespace issues in testing
by jhourcle (Prior) on Feb 28, 2006 at 14:49 UTC

Some people would argue that defining a primary key to be 'NOT NULL' is redundant as well, so a statement without it should be considered the same. (I'm not sure if that's a function of the database, though, which might introduce extra complexity).

PS. back when I took Oracle's SQL Tuning class (back in 2001 or so), we were told that the caching only worked for exact string matches -- any whitespace or capitalization changes would be considered a different query to the optimizer.

[reply]