in reply to Strings with @

#! /usr/bin/env perl use strict; use warnings; open my $f, 'netapsp' or die "open failed: $!"; my $recip = 'some.g.guy@bigcorp.com'; while (<$f>) { chomp; system "rsh $_ quota report | mail $recip" and die "rsh failed: $!"; }

Morever, with such a simple program you've little excuse to not use tainting (perldoc perlsec), which would've suggested that you verify what you get from 'netapps' rather than blindly pass it to a shell.

Replies are listed 'Best First'.
Re^2: Strings with @
by stubblyhead (Initiate) on Mar 10, 2006 at 17:18 UTC
    while (<$f>) { chomp; system "rsh $_ quota report | mail $recip" and die "rsh failed: $!"; }
    shouldn't that be or die rather than and die?

      No, it should not. Unix programs return 0 on success.