Re: RFC: CGI/MySQL - improving my code

A few basics:

Use a config file. This database login stuff does not belong in your application code.
Don't write your own HTML escaping code. Use CGI or HTML::Entities.
Use templating to get the HTML out of your code.
Use CGI::Application or something similar to get rid of that if/elsif tree for $action.
Turn RaiseError on for DBI.

Also, if you want detailed responses, post less code. It would take hours to go through this code carefully.

Comment on Re: RFC: CGI/MySQL - improving my code

Replies are listed 'Best First'.
Re^2: RFC: CGI/MySQL - improving my code by Melly (Chaplain) on Mar 27, 2006 at 18:55 UTC
To be honest, I didn't expect anyone to go through my code - I'll revise my text to indicate that - it was more meant as an example of how a combination of lack of knowledge and planning can lead to messy code. What I'd really like to do is have an orphaned node that I can just link to (the code ought to be available, but doesn't need to be in the main body of the article). I'd really like to create a more structured article than (afaik) perlmonks allows - e.g. comments only accessable if you request them. Tom Melly, tom@tomandlu.co.uk	[reply]

Replies are listed 'Best First'.

Re^2: RFC: CGI/MySQL - improving my code
by Melly (Chaplain) on Mar 27, 2006 at 18:55 UTC

To be honest, I didn't expect anyone to go through my code - I'll revise my text to indicate that - it was more meant as an example of how a combination of lack of knowledge and planning can lead to messy code.

What I'd really like to do is have an orphaned node that I can just link to (the code ought to be available, but doesn't need to be in the main body of the article).

I'd really like to create a more structured article than (afaik) perlmonks allows - e.g. comments only accessable if you request them.

Tom Melly, tom@tomandlu.co.uk

[reply]