Re: XML-Twig - AS5.6.1 vs AS 5.8.8

There are a few problems with your code:

first, as mentionned by runrig, you delete $balance and then you flush it. So $balance is deleted, and becomes undef-ed, so you can't call a method on it (are you sure this code worked in 5.6.1?)

you do a couple of times things like this:

    my $balance30elt = new XML::Twig::Elt('BAL_30', $balance30);
    $balance30elt->set_text($balance30);
    $balance30elt->set_att(Period => 1);
    $balance30elt->paste('first_child', $balance);
[download]

The set_text is completely useless (you set the text in the new above, and BTW new XML::Twig::Elt is a deprecated way of calling a method, XML::Twig::Elt->new is the proper way.
In any case, you can replace all those lines by the more compact

    $balance->insert_new_elt( first_child,     # position
                              'BAL_30',        # tag
                              { Period => 1 }, # attributes
                              $balance,        # content
                            );
[download]

And actually it looks like you don't even need to delete then re-create the BAL_30 (and BAL_60) element. You could just do:

   $balance->first_child( 'BAL_30') # get the element
           ->del_atts               # if it had atts originally
           ->set_att( Period => 1)
           ;
[download]

Does it make sense?

Comment on Re: XML-Twig - AS5.6.1 vs AS 5.8.8 Select or Download Code

Replies are listed 'Best First'.
Re^2: XML-Twig - AS5.6.1 vs AS 5.8.8 by drmikec (Initiate) on Mar 29, 2006 at 21:00 UTC
Yes, it does. Thanks, Michael. I implemented the method calls as you suggested, and it works, except for one small thing - the first time `$balance->flush;` is called, it writes a `<Root>` tag immediately preceding the `<Aging>` tag. As you can surmise, I'm processing a member billing file, and it doesn't write the `<Root>` tag on subsequent members, just the first one. I can hack my way around it, but I don't understand why it is happening. Thanks. -Mike	[reply] [d/l] [select]
Re^3: XML-Twig - AS5.6.1 vs AS 5.8.8 by runrig (Abbot) on Mar 29, 2006 at 22:13 UTC
A minimal test case with data would be helpful. Do you mean that each Aging element is a child of a different Root element? And that the parent element of your entire document is some other-named sort of "root" element? Or that all of your Aging elements are children of one Root element (in which case it sounds like it's behaving correctly)?	[reply]
Re^4: XML-Twig - AS5.6.1 vs AS 5.8.8 by drmikec (Initiate) on Mar 29, 2006 at 22:39 UTC
Thanks for your previous response and this one, runrig. Here is the head of the original file. All of the tags that are opened above the `<Aging>` tag are subsequently closed properly. Names have been changed to protect the innocent: <?xml version="1.0" encoding="ISO-8859-1"?> <Root> <Billing> <STMT_HDR.AR> <StatementDate>20060228</StatementDate> <PreviousDate>20060131</PreviousDate> <DueDate>20060331</DueDate> <TransactionThruDate>20060228</TransactionThruDate> <MemberId> <MemberNumber>1000</MemberNumber> <MemberInfo> <MemberName>Mickey Mouse</MemberName> <Address> <Address1>6340 Disney Lane</Address1> <Address2>P.O. Box 730</Address2> <Address3></Address3> <City>Orlando</City> <State>FL</State> <ZipCode>33333</ZipCode> </Address> </MemberInfo> <BillingInfo> <PreviousBalance>2371.28</PreviousBalance> <ChargeTotal>567.78</ChargeTotal> <PymtAdjustTotal>2371.28</PymtAdjustTotal> <EndingBalance>567.78</EndingBalance> <AutomaticBilling> <Minimum>False</Minimum> <BillingCode></BillingCode> <BillingBalance></BillingBalance> </AutomaticBilling> <Aging> <BAL_30 Period="1">0.00</BAL_30> <BAL_60 Period="2">0.00</BAL_60> <BAL_90 Period="3">0.00</BAL_90> <BAL_120 Period="4">0.00</BAL_120> <BAL_150 Period="5">0.00</BAL_150> <BAL_180 Period="6">0.00</BAL_180> </Aging> [download] Here is the result of the modifications: All is the same prior to this point - `<BillingInfo> <PreviousBalance>2371.28</PreviousBalance> <ChargeTotal>567.78</ChargeTotal> <PymtAdjustTotal>2371.28</PymtAdjustTotal> <EndingBalance>567.78</EndingBalance> <AutomaticBilling> <Minimum>False</Minimum> <BillingCode></BillingCode> <BillingBalance></BillingBalance> </AutomaticBilling> <Root> <--This is the question <Aging> <BAL_30 Period="1">0.00</BAL_30> <BAL_60 Period="2">0.00</BAL_60> <BAL_90 Period="3">0.00</BAL_90> </Aging>` [download] Your help is greatly appreciated. -Mike	[reply] [d/l] [select]
Re^5: XML-Twig - AS5.6.1 vs AS 5.8.8 by runrig (Abbot) on Mar 30, 2006 at 21:37 UTC