in reply to A pretty simple perl script..
Not sure why you're putting your file globbing results in @ARGV. The preferable way is to use the glob function. Personally, I'd do something like...@ARGV = <$LOGDIR/*.log>;
my @fileList = glob($LOGDIR/*.log); while (@fileList) { ... }
Are you sure you want to remove all 'L's? What if someone's name has an 'L' in it? How about...s/L//;
You should always try to use strict too.
I hope I don't come across as overly harsh, but this script needs some cleaning up. There are many more issues. These are a few that jumped out at me right away.
|
|---|
| Replies are listed 'Best First'. | |
|---|---|
|
Re^2: A pretty simple perl script..
by GrandFather (Saint) on Mar 30, 2006 at 21:48 UTC |