mkdir in a loop?

Anonymous Monk has asked for the wisdom of the Perl Monks concerning the following question:

hi monks,

I have a list of filenames, and for each one I want to create a directory with that filename. However, I keep getting directories with '?' on the end that don't actually seem to exist. Can anyone advise? Thanks!

open (FILE, "all_controls.txt") or die "can't open file $!";

my @file=<FILE>;

foreach my $file (@file)   {
        mkdir "$file";
}
[download]

Comment on mkdir in a loop? Download Code

Replies are listed 'Best First'.
Re: mkdir in a loop? by ambrus (Abbot) on Apr 05, 2006 at 09:31 UTC
`chomp(my @file = <FILE>);` [download]	[reply] [d/l]
Re: mkdir in a loop? by murugu (Curate) on Apr 05, 2006 at 09:46 UTC
`open (FILE, "all_controls.txt") or die "can't open file $!"; my @file=<FILE>; chomp @file; foreach my $file (@file) { mkdir "$file"; }` [download] Regards, Murugesan Kandasamy use perl for(;;);	[reply] [d/l]
Re: mkdir in a loop? by wand3ringscript3r (Initiate) on Apr 05, 2006 at 15:01 UTC
`Check "all_control.txt" for any extra formatting characters. #!/usr/bin/perl use strict; my $file = "all_controls.txt"; open(FILE, "<$file") \|\| die "Unable to open $file: $!\n"; my @file_contents = <FILE>; foreach (@file_contents) { chomp; $_ =~ /^(.?)\..?$/; # remove filename extension mkdir ($1, 0755) \|\| die "Unable to create directory: $!\n"; print "Created directory: $1\n" if (! $@); } # end` [download]	[reply] [d/l]
Re: mkdir in a loop? by wand3ringscript3r (Initiate) on Apr 05, 2006 at 14:54 UTC
I noticed the "?" mark too. Check the "all_control.txt" file to see if it has any extra formatting characters. Then the following should work fine. `#!/usr/bin/perl use strict; my $file = "all_controls.txt"; open(FILE, "<$file") \|\| die "Unable to open $file: $!\n"; my @file_contents = <FILE>; foreach (@file_contents) { chomp; $_ =~ /^(.?)\..?$/; # remove filename extension after '.' mkdir ($1, 0755) \|\| die "Unable to create directory: $!\n"; print "Created directory: $1\n" if (! $@); } # end` [download] Edit: g0n - code tags	[reply] [d/l]