in reply to Edit a List of Files

A mixture of, mostly minor, stylistic issues:

use strict; use warnings;

That mantra should come before you do anything else! Always! Regardless of projet size! No exceptions! Comprende?

(condition) or print "fail string";

is cute, but

print "fail string" if condition;

is clearer. In cases where the fail condition is non-zero it is even better to make it explicit:

print "fail string" if 0 != (condition);

It is tempting to comment things that you have just learned, but that can lead to over commenting and make it harder to grok the flow of the code.

$var1 . 'string1' . "string2" is better written as "${var1}string1string2". Note the ${var1} usage to clarify where the variable name ends.

The block for while (<FILE2CHANGE>) { is not indented.


DWIM is Perl's answer to Gödel

Replies are listed 'Best First'.
Re^2: Edit a List of Files
by lev36 (Sexton) on Apr 11, 2006 at 20:54 UTC

    Thanks!

    I added use strict;, and fixed the indent problem. As for use warnings;, doesn't the "-w" in #!/usr/bin/perl -w do the same thing?

    I don't have time right now, but I'll review the script and consider your other suggestions as well. I do appreciate it!

      Yes, -w does do that. I tend not to notice it because on Windows I don't need (and therefore don't supply) the shebang line.


      DWIM is Perl's answer to Gödel