Can I use something other than sth?

Just a couple of other quick pointers that may save you some grief further down the track:

• try to get into the habit of always checking the return values of your DBI calls. The general way to do this is:

  my $dbh = DBI->connect("DBI::ODBC ... etc $dsn") 
      or die("Couldn't connect to $dsn: $DBI::errstr\n");
  [download]

• another good habit to get into is to use placeholders wherever you can. This a safer method and ensures that your strings will always be properly quoted. For example, instead of:

  my $sth = $dbh->prepare("INSERT INTO table VALUES (value1, value2, val
  +ue3)");
  [download]

  You would do:

  my $sth = $dbh->prepare("INSERT INTO table VALUES (?, ?, ?)");
  [download]

  and then later...

  $sth->execute($foo, $bar, $baz);
  [download]

Cheers,
Darren :)

my $sth_ins = $dbh->prepare("INSERT ....");
my $sth_sel = $dbh->prepare("SELECT ....");
...
$sth_ins->execute();
...
$sth_sel->execute();
while( my $row = $sth_sel->fetchrow_arrayref() ){
  ...
}
[download]

Thanks David, I'll give that a shot and see how it goes. I figured it would be something simple. I'll be glad when I'm comfortable enough with perl to deal with stuff like this without asking.

Thanks for the replies, gentlemen. Now I've pretty much mangled the code but it almost works. The only problem is that the insert statement is inserting a blank row each time with no data in each column. The insert code i'm using is:

my $sth_ins = $dbh->prepare("INSERT INTO users (firstname, lastname, s
+tate, country) VALUES (?, ?, ? ,?)") or die "Couldn't insert the data
+";
$sth_ins->execute($FORM{firstname}, $FORM{lastname}, $FORM{state}, $FO
+RM{country});
[download]

I was talking about this problem with a friend of mine who is vaguely familiar with Perl and he mentioned that $FORM{value} was the only way to retrieve the data from

read(STDIN, $buffer, $ENV{'CONTENT_LENGTH'});
@pairs = split(/&/, $buffer);
foreach $pair (@pairs) {
    ($name, $value) = split(/=/, $pair);
    $value =~ tr/+/ /;
    $value =~ s/%([a-fA-F0-9][a-fA-F0-9])/pack("C", hex($1))/eg;
    $FORM{$name} = $value;
}
[download]

Is there another way to do it or am I just overlooking something the way it is now?

if the row is blank, then i suspect that %FORM is empty/bad .. to verify, do:

use Data::Dumper;
print Dumper \%FORM;
[download]

But yeah, don't parse the data yourself to begin with -- use CGI:

use CGI qw/:standard/;
$sth_ins->execute( param('firstname'), param('lastname'), param('state
+'), param('country') );
[download]