Re^5: Perl CGI and SQL statements

Thanks, The snippet now looks like this:

my $db = new Win32::ODBC('$DSN');

if (defined $dept) {
    if (exists $labels{$dept}) {
        # FIXME
        # untaint $dept and put it into database
        print
            $cgi->start_html,
            $cgi->p("$dept was received.");
            $cgi->end_html;
        if ($dept eq "CA") {
          if (!($db=new Win32::ODBC('$DSN'))) {
              $cgi->p("Error connecting to Database");
              $cgi->p("Error: " . Win32::ODBC::Error ) . " ");
               }
my $SqlStatement ='SELECT * FROM Pipeline WHERE Publish<="19 Apr 2006"
+ AND Expiry>="19 Apr 2006" AND CA="Must Read"';
print $SqlStatement;
   $db->Sql('$SqlStatement');
[download]

I'm still getting this error:

:\Perlcgi\Pipeline\cgi.pl: Can't call method "Sql" on an undefined val
+ue at E:\Perlcgi\Pipeline\cgi.pl line 51.
[download]

Line 51 is: $db->Sql('$SqlStatement'); It's like it won't substitute the contents $SqlStatement or something? Why is that?

Incidentally, if I drop in the SQL Statement in that Line 51 code it still gives the same error message. Does CGI need me to express the $db->Sql() differently?

Comment on Re^5: Perl CGI and SQL statements Select or Download Code

Replies are listed 'Best First'.
Re^6: Perl CGI and SQL statements by osunderdog (Deacon) on Apr 19, 2006 at 13:44 UTC
`my $db = new Win32::ODBC('$DSN');` Firstly, you need to either remove the tic marks or use double quotes. The way this is written, you're sending exactly `$DSN` as a string. If you want to send what `$DSN` is set to, then use: `my $db = new Win32::ODBC($DSN);` Secondly, this probably explains the next problem... `$db` is undefined because the instance creation failed. In other words, after you do this: `my $db = new Win32::ODBC($DSN);` You should check `$db` to verify that the object was created successfuly. If it could not connect, then `$db` will be undefined. The error you are seeing is because you can't call the function `Sql` on an undefined `$db` variable. Seriously, a little time with the perl debugger, now that you've got compilable code, would help you understand what's going on. Neat Debugger tricks Re: Linux vs. Windows for Learning Perl perl debugger Hazah! I'm Employed!	[reply] [d/l] [select]
Re^6: Perl CGI and SQL statements by ptum (Priest) on Apr 19, 2006 at 13:33 UTC
In order for your variables to be interpolated, you must used double-quotes instead of single quotes (or none at all in this case would do as well). `$db->Sql($SqlStatement);` [download] or possibly: `$db->Sql("$SqlStatement");` [download] Either of those ought to work. I take it there is no return value to the Sql method, or perhaps you should be capturing that return? No good deed goes unpunished. -- (attributed to) Oscar Wilde	[reply] [d/l] [select]