Re^2: clean code

Make that split(/=/, $pair, 2) and your values will be allowed to have equals signs.

For most casual applications, I usually use split(/\s*=\s*/, $pair, 2). I like spaces. I'd do the same for the semicolon split. But considering the comment (this is from a serialized db row), I doubt there's much point.

To be more robust (specifically: to allow arbitrary characters in the names and values), I agree with the suggestions to use URI escaping. Since you're programmatically generating the data you're parsing, there's no reason not to do the job right -- your first concern should be correctness, second should be basic human readability (so you can tell what's going on), and a very distant third should be human writability (for debugging, casual testing, off-the-cuff model manipulation, etc.)

Comment on Re^2: clean code Select or Download Code

Replies are listed 'Best First'.
Re^3: clean code by creamygoodness (Curate) on Apr 23, 2006 at 18:21 UTC
sfink++ on the additional argument to split(). As for the comment, the original post did not make clear the purpose of the code block. I always code in commented paragraphs (as per Perl Best Practices), and such comments should be as specific as possible. However, I didn't want to make a big deal about that personal stylistic choice it because it wasn't germane. Several other posters made what I think was a reasonable assumption that the purpose of the block was CGI processing, presumably based on the structure of the data and the name of the `$memory_data` variable. Processing of CGI query strings raises a host of issues I didn't want to get into, so I made a different assumption about the nature of the data. :) -- Marvin Humphrey Rectangular Research ― http://www.rectangular.com	[reply] [d/l]

Replies are listed 'Best First'.

Re^3: clean code
by creamygoodness (Curate) on Apr 23, 2006 at 18:21 UTC

sfink++ on the additional argument to split().

As for the comment, the original post did not make clear the purpose of the code block. I always code in commented paragraphs (as per Perl Best Practices), and such comments should be as specific as possible. However, I didn't want to make a big deal about that personal stylistic choice it because it wasn't germane.

Several other posters made what I think was a reasonable assumption that the purpose of the block was CGI processing, presumably based on the structure of the data and the name of the $memory_data variable. Processing of CGI query strings raises a host of issues I didn't want to get into, so I made a different assumption about the nature of the data. :)

--
Marvin Humphrey
Rectangular Research ― http://www.rectangular.com

[reply]
[d/l]