in reply to Accessing data from a dynamic database/table

Here's another, untested, approach. I'm going to assume that $id, your first-level key, is supposed to be the primary index of the table. A hash implies uniqueness of the keys, otherwise you'd lose data.

The task is to produce a hash, %kol, which contains a table's primary index values as top-level keys, and a hash of each row's other field/value pairs at the second level.

That second-level hash will almost fall in our lap if we use fetchrow_hashref() to read the table. There will be no need to hardcode or independently determine the column names.

First, though, we need to find out what the primary key is. You've assumed it will be id, but lets generalize and make this thing work for any table with a primary index. I'll leave out the connection and all that other stuff, picking up at your # Method n comment.

# Method Z my @key_columns = $dbh->primary_key( $catalog, $schema, $table);
Instead of relying on a count while reading the table to limit the number, we'll tell the database to do it for us.Oops, misthunk, lets have no limits.
# my $limit = 6; my $select = $dbh->prepare("select * from $table");# LIMIT $limit"); $select->execute();
Now we loop through fetchrow_hashref to get a col/val hash of each row. For each, we'll delete the primary key columns, welding together their values to make a top-level key for %kol ( it may be a little unfamiliar to use delete that way, but it's a handy trick). What's left in the $row hashref is exactly what you want for the second-level hash, so we just plug that reference right in there.
while (my $row = $select->fetchrow_hashref()) { my $key = join '', delete @{$row}{@key_columns}; $kol{$key} = $row; }
That's it! You may want to join the key elements using some unlikely character like "\0", just in case you want to extract them from the key later. We didn't need to call finish() on any handles because we didn't leave anything unread.

I have no idea how that will benchmark. It avoids a good bit of data copying, so it ought to be competitive.

After Compline,
Zaxo

Replies are listed 'Best First'.
Re^2: Accessing data from a dynamic database/table
by rsiedl (Friar) on May 09, 2006 at 07:17 UTC
    Thanks Zaxo,

    Plugged it in and got the following results:
    Method 3 -------- Benchmark Time: 0.010 cpu seconds Sample Results: KOL ID:: 32 KOL RANK:: 32 KOL ID:: 33 KOL RANK:: 21 KOL ID:: 21 KOL RANK:: 24 KOL ID:: 7 KOL RANK:: 5 KOL ID:: 26 KOL RANK:: 1 KOL ID:: 2 KOL RANK:: 29
    Cheers,
    Reagen

      I see the rank data differs. Has the data changed since the run you showed?

      I'm glad if it works for you. Some of the introspective DBI methods like primary_key() are fairly recent additions to the module.

      After Compline,
      Zaxo

        ah, yep - that was run on a different table. same structure / different data.