Re: Encode::decode_utf8 and references

Um, just curious about this, but... what is the point (the purpose, benefit, short-cut or whatever) of passing a hashref to Encode::decode_utf8()?

If you were actually expecting to set the utf8 flags on the keys and values of the hash that is being passed by reference, that would simply be a misconception in your code. (But I gather that was not the intention.)

If it's just a situation that you are doing something with a list of who-knows-what, and you're just passing every element of the list to decode_utf8, regardless of what it might be, well, that seems a bit silly. You didn't show an actual snippet from the application in question, but I think it might be better for you, if your code looks something like this:

    @olist = map { decode_utf8( $_ ) } @ilist;
[download]

to just add a little bit to make it sensible, like this:

    @olist = map { (ref() ? $_ : decode_utf8( $_ ) } @ilist;
[download]

Given what you've said, I'd suggest that you treat the problem as a bug in your app -- functions intended for strings should not be applied to references. (You wouldn't pass a hashref to substr() or index(), would you?)

Comment on Re: Encode::decode_utf8 and references Select or Download Code

Replies are listed 'Best First'.
Re^2: Encode::decode_utf8 and references by samtregar (Abbot) on Jun 18, 2006 at 03:25 UTC
Um, just curious about this, but... what is the point (the purpose, benefit, short-cut or whatever) of passing a hashref to Encode::decode_utf8()? Your guess is as good as mine. I didn't write this code - I just maintain it. If there's no easy way to restore the behavior of prior versions then I'll probably end up either overriding it (ala the other suggestions) or auditing the code for bad calls to decode_utf8(). (You wouldn't pass a hashref to substr() or index(), would you?) No, I wouldn't. But to be fair to the original coder, this did work for the entire time he was on the project. I doubt that any of us write code that's safe from all possible changes that could be justified in the future! -sam	[reply]

Replies are listed 'Best First'.

Re^2: Encode::decode_utf8 and references
by samtregar (Abbot) on Jun 18, 2006 at 03:25 UTC

Um, just curious about this, but... what is the point (the purpose, benefit, short-cut or whatever) of passing a hashref to Encode::decode_utf8()?

Your guess is as good as mine. I didn't write this code - I just maintain it. If there's no easy way to restore the behavior of prior versions then I'll probably end up either overriding it (ala the other suggestions) or auditing the code for bad calls to decode_utf8().

(You wouldn't pass a hashref to substr() or index(), would you?)

No, I wouldn't. But to be fair to the original coder, this did work for the entire time he was on the project. I doubt that any of us write code that's safe from all possible changes that could be justified in the future!

-sam

[reply]