in reply to Re: Re (tilly) 1: How to call other programs
in thread How to call other programs

If I am not mistaken, $foo will not stayed shared is a sign that they are using as globals the same thing that you declared to be lexical. That can be fixed by moving the functionality of how you do a call into its own module that doesn't have any lexicals.

But have you trapped the case where they are using the same global variables as each other?

You can fix that, sort of, by wrapping your do in an eval that puts each invocation into a private package. Of course if they use package also, you are out of luck again on the global issue. Likewise if they sometimes refer to variables as being explicitly in package main. Not to mention the joys of global signal handlers.

Please trust me when I say I have the scars and don't recommend that route long-term. Refactoring the code into modules is not that hard, and once done you gain a lot of flexibility.

  • Comment on Re (tilly) 3: How to call other programs

Replies are listed 'Best First'.
Re: Re (tilly) 3: How to call other programs
by Jonathan (Curate) on Feb 02, 2001 at 14:01 UTC
    Thank you for the follow up.
    The main cause of the sharing warning (as far as I can see) is my own scripts because I'm using Apache::Registry which means that my scripts run via a handler sub (there are no warnings when run off-line).
    I think I'll have to make the sub routines anonymous to get round it.
      If you are using lexical variables as globals, then use vars - that is what it is for.

      Also if you can you want to move the bulk of the functions in question into their own modules. When your script runs it can then load the module and call functions from there. Why?

      1. Shared warnings go away.
      2. There is less work required per invocation of your script.
      3. I believe you will consume less memory.

      OK, so it will separate code into different files, and that does tend to require more thought. The basic template I would suggest using looks something like this. If your module is MyStuff.pm, then start it like this:

      package MyStuff; @ISA = 'Exporter'; @EXPORT_OK = qw(really neat functions here); use strict; # etc, including those neat functions 1; # An unfortunately necessary annoyance
      And then you use it like this:
      use MyStuff qw(neat functions); # Whatever you actually need # Proceed to call "neat" and "functions like normal # functions. You only get the ones which you list. This # is a GOOD thing because it makes it easier to track down # which function came from where!
      This is your basic procedural module. While writing it, it is good to put some thought to how to reuse the functions elsewhere...
        O.K You've convinced me. I'll do as you suggest. Thanks for your help tilly