Re: Passing a parameter to a callback

Your indentation of comments sucks. When you indent, indent everything in that block. You've destroyed the visual look of indentation and removed it as a tool to see code structure. Don't do that. Here's your code run through perltidy.

#!/usr/bin/perl -w
use strict;
use Data::Dumper;
use File::Find;

# Global array for the accumulated files...
my @files = ();

# Any directory will suffice here...
my $file_dir_root = "/var/log";

#------------------------------------------------
sub findNewerThan {

    #------------------------------------------------
    #  my $days_ago = shift;
    my $filename = $File::Find::name;
    return unless -f $filename;

    # Now stat the file to compare its modification time
    # with the days_ago parameter...

    push( @files, $filename );
}

#------------------------------------------------
sub days($) {

    #------------------------------------------------
    my $days   = shift;
    my $oneday = 60 * 60 * 24;
    return $days * $oneday;
}

#------------------------------------------------
#   MAIN
#------------------------------------------------
my $func = \&findNewerThan;

#find($func->(days(5)), ($file_dir_root) );
find( $func, ($file_dir_root) );

print Dumper( \@files );
[download]

⠤⠤ ⠙⠊⠕⠞⠁⠇⠑⠧⠊

Comment on Re: Passing a parameter to a callback Download Code

Replies are listed 'Best First'.
Re^2: Passing a parameter to a callback by thezip (Vicar) on Jul 19, 2006 at 21:47 UTC
I'm not sure I follow what you're trying to say here. I didn't do any special indentations... in my submitted source code none of the comments were indented. Please explain further... Where do you want them* to go today?*	[reply]
Re^3: Passing a parameter to a callback by runrig (Abbot) on Jul 19, 2006 at 22:02 UTC
The comments diotalevi is referring to are the lines below the function definitions, which (I assume) are meant to highlight the function names. He is saying that those lines, being unindented after a '{' defining a new code block, are wrong (would he like it more if the "{" came after the comment line? I don't know). I would disagree since highlighting the function name like that is a somewhat common practice (though I wouldn't do it), so I'd say it's somewhat acceptable, although perltidy doesn't have an option to handle it, so you will lose the formatting if your program is ever run through perltidy. I've seen the practice a lot in other languages (that don't use {} for blocks mostly) but not much in perl. The other unindented comment is where you have "`# Now stat the file to compare its modification time`", which I assume is a temporary placemarker for actual code and so I wouldn't really worry about that either since making markers like that ugly make them easy to find when you need to replace them.	[reply] [d/l]
Re^3: Passing a parameter to a callback by diotalevi (Canon) on Jul 19, 2006 at 21:48 UTC
Yes, that's the problem. I've just told you that the way your formatted your code isn't any good. It destroyed important information. It's as close to having no indentation as is possible while still having some. ⠤⠤ ⠙⠊⠕⠞⠁⠇⠑⠧⠊	[reply]
Re^4: Passing a parameter to a callback by thezip (Vicar) on Jul 19, 2006 at 21:58 UTC
You're not being especially constructive here... Are you saying that I mistakenly included a comment line just after the "sub" declaration? My bad... You'll notice that lines within a sub (with the one above exception) are indented one level, and everything not in a sub is not indented. This isn't how it should be done??? If I may ask, how would you have done it? Where do you want them* to go today?*	[reply]
A reply falls below the community's threshold of quality. You may see it by logging in.