in reply to Re: and this or that
in thread and this or that

Aside from the minor problem of using $_ where you mean to use $next, there are two problems with
opendir(PWD,"$next") && my @files = readdir PWD or die "Open \"$_\" failed: $!";

First, you waste future readers' time. The few seconds you've saved by writing the above rather than

opendir(PWD,$name) or die "$name: $!"; my @files = readdir(PWD) or die "$name: $!";
Have just eclipsed by N x "what's this? uh.. oh, I see". Better, in my humble opinion, to write straightforward code. Sure, you have code "or die" twice, but in the scheme of things, that's a really minor nit.

Second, in the unikely event that opendir() succeeds and readdir() fails, you're presenting a misleading diagnostic.

Replies are listed 'Best First'.
Re: Re: Re: and this or that
by MeowChow (Vicar) on Feb 06, 2001 at 01:53 UTC
    Which is exactly why I said:

    "In this specific example, I would not combine the readdir and openddir in one line. "

    I was re-cycling his example code simply to make another point about operator precedence.

      Mea culpa. I misread you.